Skip to content

Rename Website Payments Pro gateway slug from paypal to paypalwpp#3579

Draft
ideadude wants to merge 6 commits intodevfrom
paypal-wpp-rename
Draft

Rename Website Payments Pro gateway slug from paypal to paypalwpp#3579
ideadude wants to merge 6 commits intodevfrom
paypal-wpp-rename

Conversation

@ideadude
Copy link
Member

(Written by Flint/Claude Code)

All Submissions:

Changes proposed in this Pull Request:

Renames the deprecated Website Payments Pro (WPP) gateway slug from paypal to paypalwpp, freeing up the paypal slug for the new PayPal REST API add-on plugin (pmpro-paypal).

The old WPP gateway has held the paypal slug since the early days of PMPro, but it uses the deprecated NVP/SOAP API and is already listed as a deprecated gateway. Renaming it to paypalwpp allows the new modern PayPal integration (Orders V2 + Subscriptions API v1) to claim the clean paypal slug as an add-on gateway.

Files changed (8):

File Change
classes/gateways/class.pmprogateway_paypal.phpclass.pmprogateway_paypalwpp.php File renamed. Class PMProGateway_paypalPMProGateway_paypalwpp. All self-references, gateway slug checks, and CSS classes updated.
includes/deprecated.php 'paypal''paypalwpp' in pmpro_get_deprecated_gateways()
includes/functions.php $gateway == 'paypal'$gateway == 'paypalwpp' in gateway ready check
services/ipnhandler.php pmpro_doing_webhook('paypal')'paypalwpp'; $morder->gateway == "paypal""paypalwpp"
includes/updates/upgrade_3_2.php 'paypal''paypalwpp' in upgrade check
includes/updates/upgrade_1_4_2.php $gateway == "paypal""paypalwpp" in SSL default check
classes/class-pmpro-site-health.php 'paypal' =>'paypalwpp' => in gateway constants map
classes/class-pmpro-wisdom-integration.php 'paypal' =>'paypalwpp' => in gateway settings detection

NOT changed: PAYPAL_BN_CODE constant (static partner attribution ID, not a gateway slug). Hook names like pmpro_paypal_handle_http_post_response and pmpro_paypal_level_description are left as-is since they are public API.

Note: This PR does not include a database upgrade routine to migrate existing WPP users from the paypal slug to paypalwpp. That should be handled in a separate upgrade routine when this ships. Sites currently using WPP will need their pmpro_gateway option updated from paypal to paypalwpp.

How to test the changes in this Pull Request:

  1. On a test site with PMPro active and gateway set to "PayPal Website Payments Pro", verify the gateway continues to appear in the settings dropdown after applying this branch.
  2. Confirm the settings page renders correctly with the renamed CSS classes (fields show/hide when selecting the gateway).
  3. Verify that the IPN handler still loads correctly at admin-ajax.php?action=ipnhandler.
  4. Search the codebase for any remaining == 'paypal' or == "paypal" references that should have been renamed (excluding paypalexpress, paypalstandard, and the PAYPAL_BN_CODE constant).
  5. Confirm no PHP syntax errors: php -l on all changed files.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Renamed the deprecated Website Payments Pro gateway slug from paypal to paypalwpp to free up the paypal slug for the new PayPal REST API add-on plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants