Fix for component level relations not being purged #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in another PR (#86) and bug #66
we were having issues with components that contain relations not getting their cache invalidated/purged.
We've done a lot of testing on this (just finalising front end QA), and it appears to now be working as it should (Strapi v4.24.4)
The issue stems from actually extracting the models correctly, but not in the end adding them to the relatedModels array.
A very, very simple change in the end, but like I say, we have tested this and it appears to be working.
Hope this is enough info and you find it useful, and I'm not barking up the wrong tree.
TVM for the plugin, using it very heavily now!