-
-
Notifications
You must be signed in to change notification settings - Fork 41
Core: Update to Strapi 5 stacked #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o easily import them
…one at a later stage
…port questions on the documentation website
…n-rest-cache into dev/v5-docs
…-cache into dev/update-cache-manager
…m the root of the repository
…n-rest-cache into dev/v5-docs
…-cache into dev/update-cache-manager
|
@derrickmehaffy I've now fixed the React error you've mentioned. It seems on my side Keyv 4 is being preferred over Keyv 5. That's why I didn't run into the issue with |
|
Cool, I'll manually do another alpha release today after lunch and start diving into my more in depth testing but so far we are on the right track. I also want to run a security audit and look for any other packages updates we can do without breaking too much. |
7305269 to
3812f76
Compare
|
Found a bug @boazpoolman looks like the TTL (maxAge) is broken, it's not setting the TTL in both providers (at least I think on memory, difficult to check)
|
|
I see why, since cache-manager moved to Keyv, the way you pass in the TTL is different. Before we were constructing an options object but they expect just an integer: https://www.npmjs.com/package/cache-manager#set What we are doing is: But it should just be (I think) |
|
Alright so far my testing is pretty well done #111 Going to merge this and get stuff in the right branches |









This is a stacked PR, branched off of
dev/update-cache-manager.This PR introduces some changes to make the
e2etests work with v5. After the tests started working again they helped to pin point a regression introduced with the v5 migration of this plugin. Managed to solve that here also.Update checklist issue: #111