Increase GitHub Action checkout version to v5#445
Conversation
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
WalkthroughAll workflows update actions/checkout from v4 to v5 and add with: persist-credentials: false to each checkout step. Affected files: .github/workflows/cargo.yml, main.yml, nightly.yml. No other steps, logic, or jobs are modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/main.yml (1)
30-32: Optional: consider fetch-depth: 0 if any step relies on tags/historyIf any of the invoked Makefile tasks (e.g., release/docs) call git describe, read tags, or traverse history, the default shallow fetch (depth=1) can break those. If relevant, set fetch-depth: 0 on the checkout steps that need it.
Apply where needed:
- uses: actions/checkout@v5 with: persist-credentials: false + fetch-depth: 0.github/workflows/cargo.yml (1)
28-32: Optional: verify whether compare scripts need full git historyIf any of the comparison targets end up invoking git operations that require tags or history, you may want to unshallow the checkout for the libcryptsetup-rs working copy.
If needed, amend this step:
- uses: actions/checkout@v5 with: path: libcryptsetup-rs persist-credentials: false + fetch-depth: 0.github/workflows/nightly.yml (1)
84-86: Optional: ensure semver checks do not require git tagscargo-semver-checks typically compares against crates.io and doesn’t need repo history, but if you ever switch to a mode relying on VCS tags, consider setting fetch-depth: 0 on this checkout.
Proposed tweak if needed:
- uses: actions/checkout@v5 with: persist-credentials: false + fetch-depth: 0
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.github/workflows/cargo.yml(2 hunks).github/workflows/main.yml(7 hunks).github/workflows/nightly.yml(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (28)
- GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
- GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
- GitHub Check: fedora (make -f Makefile docs-ci, cryptsetup-devel, 38)
- GitHub Check: fedora (make -f Makefile test-loopback, cryptsetup-devel keyutils-libs-devel, 38)
- GitHub Check: fedora (make -f Makefile test-loopback, cryptsetup-devel keyutils-libs-devel, 33)
- GitHub Check: fedora (make -f Makefile build-examples, cryptsetup-devel, 33)
- GitHub Check: fedora (make -f Makefile test-mutex, cryptsetup-devel keyutils-libs-devel, 33)
- GitHub Check: fedora (make -f Makefile test, cryptsetup-devel keyutils-libs-devel, 34)
- GitHub Check: fedora (make -f Makefile release, cryptsetup-devel, 33)
- GitHub Check: fedora (make -f Makefile docs-ci, cryptsetup-devel, 34)
- GitHub Check: fedora (make -f Makefile build, cryptsetup-devel, 34)
- GitHub Check: fedora (make -f Makefile build, cryptsetup-devel, 33)
- GitHub Check: fedora (make -f Makefile test-mutex, cryptsetup-devel keyutils-libs-devel, 34)
- GitHub Check: fedora (make -f Makefile test-mutex-guard, cryptsetup-devel keyutils-libs-devel, 33)
- GitHub Check: fedora (make -f Makefile build-examples, cryptsetup-devel, 34)
- GitHub Check: fedora (make -f Makefile docs-ci, cryptsetup-devel, 33)
- GitHub Check: stable (make -f Makefile docs-ci, libcryptsetup-dev)
- GitHub Check: lowest_supported (make -f Makefile test-mutex, libcryptsetup-dev libkeyutils-dev)
- GitHub Check: lowest_supported (make -f Makefile test-mutex-guard, libcryptsetup-dev libkeyutils-dev)
- GitHub Check: stable (make -f Makefile test-mutex-guard, libcryptsetup-dev libkeyutils-dev)
- GitHub Check: typos
- GitHub Check: stable (make -f Makefile release, libcryptsetup-dev)
🔇 Additional comments (3)
.github/workflows/main.yml (1)
30-32: Checkout upgraded to v5 with credentials persistence disabled: LGTMAll checkout steps consistently use actions/checkout@v5 with persist-credentials: false. This is a solid security hardening with no change to workflow semantics.
Also applies to: 47-49, 67-69, 105-107, 134-136, 239-241, 257-259
.github/workflows/cargo.yml (1)
28-32: Consistent v5 upgrade and disabled credential persistence: LGTMBoth checkouts (repo and ci) are upgraded to actions/checkout@v5 and set persist-credentials: false. Good consistency and supply-chain posture.
Also applies to: 47-52
.github/workflows/nightly.yml (1)
18-20: Upgrade to checkout@v5 with credential persistence disabled: LGTMAll updated steps look correct across audit, checks-with-ci-repo, and semver-checks jobs. No behavioral changes expected.
Also applies to: 40-44, 59-63, 84-86
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Related stratis-storage/project#807
Summary by CodeRabbit