Skip to content

github actions: Update recommended Rust to 1.91.0#456

Merged
mulkieran merged 1 commit into
stratis-storage:masterfrom
mulkieran:rust-1.91.0
Nov 3, 2025
Merged

github actions: Update recommended Rust to 1.91.0#456
mulkieran merged 1 commit into
stratis-storage:masterfrom
mulkieran:rust-1.91.0

Conversation

@mulkieran
Copy link
Copy Markdown
Member

@mulkieran mulkieran commented Nov 3, 2025

@mulkieran mulkieran self-assigned this Nov 3, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 3, 2025

Walkthrough

Updated Rust toolchain version from 1.90.0 to 1.91.0 across three GitHub Actions workflow files. Changes include the cargo, main, and nightly workflows, affecting CI environment specifications without altering workflow logic or behavior.

Changes

Cohort / File(s) Change Summary
Rust Toolchain Version Bump
​.github/workflows/cargo.yml, ​.github/workflows/main.yml, ​.github/workflows/nightly.yml
Updated Rust toolchain version from 1.90.0 to 1.91.0 across all workflow job specifications and toolchain installation steps

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple, repetitive version string updates across three workflow files with no logic or control flow changes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • jbaublitz

Poem

🐰 Toolchains hop through time, version bumps so fine,
From 1.90 to 1.91, workflows realign!
CI checks dance in workflows three,
Ready for the future, updated with glee! ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "github actions: Update recommended Rust to 1.91.0" directly and accurately reflects the primary change in the changeset. The PR updates the Rust toolchain version from 1.90.0 to 1.91.0 across three GitHub Actions workflow files (.github/workflows/cargo.yml, .github/workflows/main.yml, and .github/workflows/nightly.yml). The title is concise, clear, and specific enough that a teammate scanning the commit history would immediately understand that the change involves updating the Rust toolchain version in CI workflows. There are no vague terms, emojis, or misleading information.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34afec2 and 569b4b0.

📒 Files selected for processing (3)
  • .github/workflows/cargo.yml (1 hunks)
  • .github/workflows/main.yml (3 hunks)
  • .github/workflows/nightly.yml (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (36)
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: fedora (make -f Makefile test-mutex, cryptsetup-devel keyutils-libs-devel, 38)
  • GitHub Check: fedora (make -f Makefile docs-ci, cryptsetup-devel, 38)
  • GitHub Check: fedora (make -f Makefile release, cryptsetup-devel, 38)
  • GitHub Check: fedora (make -f Makefile build-examples, cryptsetup-devel, 34)
  • GitHub Check: fedora (make -f Makefile test, cryptsetup-devel keyutils-libs-devel, 38)
  • GitHub Check: fedora (make -f Makefile build, cryptsetup-devel, 38)
  • GitHub Check: fedora (make -f Makefile test-loopback, cryptsetup-devel keyutils-libs-devel, 38)
  • GitHub Check: fedora (make -f Makefile test-mutex-guard, cryptsetup-devel keyutils-libs-devel, 38)
  • GitHub Check: fedora (make -f Makefile build-examples, cryptsetup-devel, 38)
  • GitHub Check: fedora (make -f Makefile test-loopback, cryptsetup-devel keyutils-libs-devel, 34)
  • GitHub Check: fedora (make -f Makefile test-mutex, cryptsetup-devel keyutils-libs-devel, 34)
  • GitHub Check: fedora (make -f Makefile release, cryptsetup-devel, 34)
  • GitHub Check: fedora (make -f Makefile test-mutex-guard, cryptsetup-devel keyutils-libs-devel, 34)
  • GitHub Check: fedora (make -f Makefile test, cryptsetup-devel keyutils-libs-devel, 34)
  • GitHub Check: fedora (make -f Makefile docs-ci, cryptsetup-devel, 34)
  • GitHub Check: fedora (make -f Makefile build, cryptsetup-devel, 33)
  • GitHub Check: fedora (make -f Makefile test-loopback, cryptsetup-devel keyutils-libs-devel, 33)
  • GitHub Check: fedora (make -f Makefile release, cryptsetup-devel, 33)
  • GitHub Check: fedora (make -f Makefile test-mutex, cryptsetup-devel keyutils-libs-devel, 33)
  • GitHub Check: lowest_supported (make -f Makefile test-mutex, libcryptsetup-dev libkeyutils-dev)
🔇 Additional comments (3)
.github/workflows/cargo.yml (1)

45-45: Rust toolchain version bump is consistent and isolated.

Version 1.90.0 → 1.91.0 is a straightforward update to the current development toolchain. The comment is preserved correctly.

Please confirm that Rust 1.91.0 is available as a stable release and that there are no known breaking changes affecting this project's CI workflow.

.github/workflows/main.yml (1)

25-25: Consistent Rust version bump across three jobs.

All three instances of the current development toolchain (format, lint, typos jobs) are uniformly updated from 1.90.0 to 1.91.0. The MSRV at line 120 (1.77.0) is correctly left unchanged. Comments are preserved.

Verify that Rust 1.91.0 is available and stable, and confirm no breaking changes affect the formatting, linting, or typos-check tooling between versions.

Also applies to: 42-42, 62-62

.github/workflows/nightly.yml (1)

24-24: Uniform Rust version updates across nightly workflow.

All four toolchain references (audit and checks-with-ci-repo jobs using dtolnay/rust-toolchain, and two semver-checks steps using cargo-semver-checks-action) are consistently updated from 1.90.0 to 1.91.0. Different action parameter names (toolchain vs rust-toolchain) are correctly preserved. Comments are maintained.

Verify that Rust 1.91.0 is available and that cargo-semver-checks-action v2 supports this toolchain version without issues.

Also applies to: 57-57, 93-93, 99-99


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran moved this to In Review in 2025October Nov 3, 2025
@packit-as-a-service
Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-libcryptsetup-rs-456
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran merged commit 710cfc1 into stratis-storage:master Nov 3, 2025
45 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in 2025October Nov 3, 2025
@mulkieran mulkieran moved this from Done to Done(3) in 2025October Nov 4, 2025
@mulkieran mulkieran moved this from Done(3) to Done(4) in 2025October Nov 4, 2025
@mulkieran mulkieran added this to the 0.14.1 milestone Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(4)

Development

Successfully merging this pull request may close these issues.

1 participant