Change signature of devs's value

[mulkieran]

Closes #4027

[mulkieran]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Walkthrough

The PR refactors device serialization in DBus response builders from wrapped Value types to plain strings in HashMap<String, String>, then removes the now-unused DevUuid and FilesystemUuid type imports and their corresponding DBus conversion trait implementations.

Changes

DBus Device Serialization Cleanup

Layer / File(s)	Summary
Device dictionary encoding refactor src/dbus/types.rs	Per-device dictionaries in LockedPoolsInfo and stopped pools now insert devnode and uuid as plain String values into HashMap<String, String> instead of using Value::from(...) wrappers.
Import and trait implementation cleanup src/dbus/types.rs	Removes DevUuid and FilesystemUuid from engine imports, and deletes their Basic, Type, and From<...> for Value trait implementations, which are no longer referenced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

bug

Suggested reviewers

• jbaublitz

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title "Change signature of devs's value" is directly related to the main change: modifying the D-Bus devs serialization signature from aa{sv} to aa{ss}, which aligns with the primary code modifications in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo dnf install -y 'dnf*-command(copr)'
• dnf copr enable packit/stratis-storage-stratisd-4030-copr_pull
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.