Fix missing signal for blockdev size on block device growth

[jbaublitz]

Closes #4026

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Block device physical size changes are now properly reported when storage operations update device configurations, ensuring accurate physical size tracking.

[mulkieran]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0d23f6e3-2a7e-4e81-8bd9-0afd7ee9fc11

📥 Commits

Reviewing files that changed from the base of the PR and between 60bf841 and 1b7d805.

📒 Files selected for processing (2)

• src/dbus/pool/pool_3_3/methods.rs
• src/dbus/util.rs

---

Walkthrough

This pull request adds D-Bus signal emission for blockdev TotalPhysicalSize changes when a pool grow operation reports a device change. A new utility function broadcasts the signal across all blockdev interface versions, and the pool grow method integrates it by looking up the device path and triggering the signal emission.

Changes

Blockdev physical size notification on pool grow

Layer / File(s)	Summary
D-Bus blockdev physical size signal utility src/dbus/util.rs	Adds imports for BlockdevR0, BlockdevR1, and BlockdevR2 interface variants and a new exported async function send_blockdev_physical_size_signal that emits total_physical_size_changed signals across all blockdev interface versions (r0–r9).
Pool grow method signal emission src/dbus/pool/pool_3_3/methods.rs	Imports the new utility function and integrates it into the grow action's action.changed() handler to emit a blockdev physical size signal when the manager successfully resolves a device UUID to a block device path; logs a warning if the path is not found.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main change: fixing a missing D-Bus signal for blockdev size when a block device is grown.
Linked Issues check	✅ Passed	The PR implements the required fix by emitting the missing blockdev physical size signal when block devices grow, directly addressing issue #4026.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the missing blockdev physical size signal emission; no unrelated modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo dnf install -y 'dnf*-command(copr)'
• dnf copr enable packit/stratis-storage-stratisd-4032-copr_pull
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.