Add coin base unit [draft] #210
Conversation
|
Nice work, ping me if you want a review. |
|
It does appear to, yes. |
| constructor(private globalService: GlobalService) { | ||
| this.baseUnitSubscription = this.globalService.baseUnit.subscribe(b => { | ||
| this.baseUnit = b; | ||
| this.format = this.format != undefined ? this.format : b.defaultFormat; |
There was a problem hiding this comment.
To be safe, I would go with !!this.format ? this.format : b.defaultFormat instead of this.format != undefined ? this.format : b.defaultFormat
| if (typeof value === 'number') { | ||
| temp = value / 100000000; | ||
| temp = value / multiple; |
There was a problem hiding this comment.
You might need to check that multiple != 0 to avoid division by 0
| @@ -10,6 +13,15 @@ export class GlobalService { | |||
| this.setSidechainEnabled(); | |||
| this.setTestnetEnabled(); | |||
| this.setApiPort(); | |||
|
|
|||
| // Store by name so we can match the object and populate the settings list correctly. | |||
| let storedBaseUnitName = localStorage.getItem('baseUnit'); | |||
There was a problem hiding this comment.
storedBaseUnitName doesn't change, use const instead of let
| @@ -105,4 +134,13 @@ export class GlobalService { | |||
| setCoinUnit(coinUnit: string) { | |||
| this.coinUnit = coinUnit; | |||
| } | |||
|
|
|||
| setBaseUnit(baseUnit: BaseUnit) { | |||
There was a problem hiding this comment.
we should probably use property get and set to simplify this:
set baseUnit(value: BaseUnit) {
localStorage.setItem('baseUnit', baseUnit.name);
this.baseUnit.next(baseUnit);
}
get baseUnits() {
return this.baseUnits;
}
| @@ -0,0 +1,16 @@ | |||
| <div class="card p-4"> | |||
| <div class="card-header">Change Base Unit</div> | |||
| <div class="card-body" style="min-height:200px;"> | |||
There was a problem hiding this comment.
Can we move all inline styles into a base-unit.component.scss
| <select class="custom-select col-12" [(ngModel)]="selectedBaseUnit" [ngModelOptions]="{standalone: true}" (change)="onBaseUnitChanged()"> | ||
| <option *ngFor="let baseUnit of baseUnits" [ngValue]="baseUnit">{{ coinUnit | prefixCoinUnit:baseUnit.name }}</option> | ||
| </select> | ||
| <span style="padding-left: 15px;">1 Strat = <coins [amount]="100000000"></coins></span> |
There was a problem hiding this comment.
Can we move all inline styles into a base-unit.component.scss
| <td class="text-left" *ngIf="transaction.transactionType == 'sent'"><strong>- {{ transaction.transactionAmount + transaction.transactionFee | coinNotation }} {{ coinUnit }}</strong></td> | ||
| <td class="text-left" *ngIf="transaction.transactionType == 'received'"><strong>+ {{ transaction.transactionAmount + transaction.transactionFee | coinNotation }} {{ coinUnit }}</strong></td> | ||
| <td class="text-left" *ngIf="transaction.transactionType == 'staked'"><strong>+ {{ transaction.transactionAmount + transaction.transactionFee | coinNotation }} {{ coinUnit }}</strong></td> | ||
| <td class="text-left" *ngIf="transaction.transactionType == 'sent'"><strong>- <coins [amount]="transaction.transactionAmount + transaction.transactionFee"></coins></strong></td> |
There was a problem hiding this comment.
We should probably move transaction.transactionAmount + transaction.transactionFee into a variable or a property to .ts file, it is used in few places
| <td class="text-left" *ngIf="transaction.transactionType == 'sent'"><strong>- {{ transaction.transactionAmount + transaction.transactionFee | coinNotation }} {{ coinUnit }}</strong></td> | ||
| <td class="text-left" *ngIf="transaction.transactionType == 'received'"><strong>+ {{ transaction.transactionAmount + transaction.transactionFee | coinNotation }} {{ coinUnit }}</strong></td> | ||
| <td class="text-left" *ngIf="transaction.transactionType == 'staked'"><strong>+ {{ transaction.transactionAmount + transaction.transactionFee | coinNotation }} {{ coinUnit }}</strong></td> | ||
| <td class="text-left" *ngIf="transaction.transactionType == 'sent'"><strong>- <coins [amount]="transaction.transactionAmount + transaction.transactionFee"></coins></strong></td> |
There was a problem hiding this comment.
We should probably move transaction.transactionAmount + transaction.transactionFee into a variable or a property to .ts file, it is used in few places
localStorage. Electron seems to support this fine but we can change it if needed.See 3091.
TODO: