Conversation
Reviewer's GuideSwitches GitHub release and PR workflows from directly invoking the autopub CLI via uv to using the official autopub GitHub Action, removes manual .autopub artifact handling, and adjusts permissions and outputs accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
for more information, see https://pre-commit.ci
|
Hi, thanks for contributing to this project! We noticed that this PR is missing a So as soon as this PR is merged, a release will be made 🚀. Here's an example of ---
release type: patch
---
Description of the changes, ideally with some examples, if adding a new feature.
Release type can be one of patch, minor or major. We use [semver](https://semver.org/), so make sure to pick the appropriate type. If in doubt feel free to ask :) |
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The output name change from
has_releasetohas-releaseinrelease.ymlmay break any other workflows or jobs that referenceneeds.release.outputs.has_release; consider keeping the original output name or adding a compatibility output if anything external depends on it. - In
pr.yml, thefail-on-missinginput is passed as a quoted string ("true"); if the action expects a boolean input, switching to an unquotedtruewould better align with typical GitHub Actions input conventions and avoid potential type issues.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The output name change from `has_release` to `has-release` in `release.yml` may break any other workflows or jobs that reference `needs.release.outputs.has_release`; consider keeping the original output name or adding a compatibility output if anything external depends on it.
- In `pr.yml`, the `fail-on-missing` input is passed as a quoted string (`"true"`); if the action expects a boolean input, switching to an unquoted `true` would better align with typical GitHub Actions input conventions and avoid potential type issues.
## Individual Comments
### Comment 1
<location> `.github/workflows/pr.yml:29-33` </location>
<code_context>
- - name: Upload .autopub artifact
- if: steps.check.outputs.has_release == 'true'
- uses: actions/upload-artifact@v4
+ uses: autopub/autopub-action@v1
with:
- name: autopub-data
- path: .autopub
- include-hidden-files: true
+ command: check
+ github-token: ${{ secrets.BOT_TOKEN }}
+ fail-on-missing: "true"
</code_context>
<issue_to_address>
**question (bug_risk):** Double‑check that always failing when no release is found matches the previous behavior across all triggers
Previously, the shell script only exited non‑zero for `pull_request_target` events. With `fail-on-missing: "true"`, failure now depends solely on the action and is no longer event‑type dependent, so other triggers could start failing where they didn’t before. To keep behavior aligned, either restrict this step with an `if: github.event_name == 'pull_request_target'` or confirm the workflow never runs for other event types.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #861 +/- ##
=======================================
Coverage 91.37% 91.37%
=======================================
Files 45 45
Lines 4419 4419
=======================================
Hits 4038 4038
Misses 381 381 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s GitHub Actions workflows to use autopub/autopub-action@v1 instead of invoking the AutoPub CLI directly, and adjusts permissions needed for publishing releases.
Changes:
- Replace AutoPub CLI (
uvx autopub ...) steps withautopub/autopub-action@v1commands in release and PR workflows - Add
contents: writepermission to enable release publishing - Minor CHANGELOG line numbering fix
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
CHANGELOG.md |
Fixes a missing line number in the changelog list. |
.github/workflows/release.yml |
Switches release workflow steps to autopub/autopub-action@v1 and adds contents: write permission. |
.github/workflows/pr.yml |
Switches PR “check for release” step to autopub/autopub-action@v1 with fail-on-missing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Summary by Sourcery
Switch GitHub release and PR workflows to use the autopub GitHub Action instead of direct autopub CLI invocations.
CI: