Fix: CI #190
Fix: CI #190
Conversation
CodSpeed Performance ReportMerging #190 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
===========================================
+ Coverage 43.34% 85.32% +41.98%
===========================================
Files 16 16
Lines 1615 1615
Branches 226 320 +94
===========================================
+ Hits 700 1378 +678
+ Misses 886 183 -703
- Partials 29 54 +25 |
Reviewer's Guide by SourceryThis pull request focuses on fixing CI tests on GitHub Actions. The changes primarily involve updating the CI workflow configuration, upgrading dependencies, and making minor adjustments to improve the testing process. Architecture diagram for updated CI workflowgraph TD;
A[GitHub Actions] -->|uses| B[actions/checkout@v4];
B -->|runs| C[setup-python@v5];
C -->|installs| D[poetry, nox, nox-poetry, coverage];
D -->|runs| E[nox -r -t tests];
E -->|generates| F[coverage xml];
F -->|uploads| G[codecov/codecov-action@v4];
H[ikalnytskyi/action-setup-postgres@v4] -->|sets up| I[PostgreSQL];
J[CodSpeedHQ/action@v2] -->|runs| K[benchmarks];
L[actions/cache@v4] -->|caches| M[~/.cache, ~/.nox, .nox];
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for adding the Here's a preview of the changelog: Resolved an issue with the BigInt scalar definition, ensuring compatibility with Python 3.8 and 3.9. The missing name parameter was added to prevent runtime errors. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Ckk3 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider updating the PR description to mention all changes, including the modification to the BigInt scalar in
scalars.py. - The removal of the Python version matrix in the lint job might reduce cross-version linting coverage. Consider keeping multi-version linting or explain the rationale for this change.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| lint: | ||
| name: ✨ Lint | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: wntrblm/nox@main | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-versions: "3.8, 3.9, 3.10, 3.11, 3.12" | ||
| python-version: | | ||
| 3.8 | ||
| 3.9 | ||
| 3.10 | ||
| 3.11 | ||
| 3.12 | ||
|
|
||
| - name: Pip and nox cache | ||
| id: cache | ||
| uses: actions/cache@v3 | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.cache | ||
| ~/.nox | ||
| .nox | ||
| key: ${{ runner.os }}-nox-lint-${{ matrix.session.session }}-${{ | ||
| key: | ||
| ${{ runner.os }}-nox-lint-${{ env.pythonLocation }}-${{ | ||
| hashFiles('**/poetry.lock') }}-${{ hashFiles('**/noxfile.py') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-lint-nox-${{ matrix.session.session }}- | ||
| ${{ runner.os }}-lint-nox- |
There was a problem hiding this comment.
suggestion (performance): Reconsider removing the caching step in the lint job
Removing the caching step for pip and nox in the lint job might slow down the CI process. Consider keeping a form of caching to improve performance, especially for frequently run jobs like linting.
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: |
3.8
3.9
3.10
3.11
3.12
- uses: actions/cache@v4
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ hashFiles('**/poetry.lock') }}
restore-keys: |
${{ runner.os }}-pip-
|
Ready for Review! I’ve updated the CI and incorporated a lot from the Strawberry repository. One key point to note: the Python 3.8 and 3.9 tests are consistently failing, and this is not related to the GitHub Actions workflow. I verified that we had previously identified this issue, as referenced in a comment by Philaeux. The issue was resolved by adding the |
* Fix: CI (strawberry-graphql#190) * creatign a new PR just to test actions * uses default github action from strawberry repo * making a test wrong to see if gets a error * make test correct again * take back poetry command * another test * test with coverage cml * add coverage package * change codecove version * change order * ops * trying wiht no async to see whats wrong with xdist * bring back async * fix: BigInt raising errors * add release md * Release 🍓 0.4.4 --------- Co-authored-by: Luis Gustavo <[email protected]> Co-authored-by: Botberry <[email protected]>
Description
Fix CI tests by updating GitHub Actions workflows.
One key point to note: the Python 3.8 and 3.9 tests are consistently failing, and this is not related to the GitHub Actions workflow. I verified that we had previously identified this issue, as referenced in a comment by Philaeux.
The issue was resolved by adding the
nameparameter to the BigInt scalar definition. This prevents an error from being raised whenstrawberry.scalaris called and__name__is searched for inside aUniontype in this part of the Strawberry code.Types of Changes
Issues Fixed or Closed by This PR
Checklist
Summary by Sourcery
Fix CI tests by updating GitHub Actions workflows to use the latest versions of actions and dependencies, including actions/checkout, actions/setup-python, and codecov/codecov-action. Replace pipx with pip for dependency installation and adjust Python version specifications and caching strategies.
Bug Fixes:
CI: