-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI with new Ubuntu LTS #198
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 85.32% 85.38% +0.06%
==========================================
Files 16 16
Lines 1615 1615
Branches 320 128 -192
==========================================
+ Hits 1378 1379 +1
Misses 183 183
+ Partials 54 53 -1 |
CodSpeed Performance ReportMerging #198 will not alter performanceComparing Summary
|
Reviewer's Guide by SourceryThis pull request addresses CI issues by updating the Ubuntu version and CodSpeed action in the test workflow. The changes are focused on fixing the "Unit tests / 💻 Generate test matrix" and "Unit tests / 📈 Benchmarks" workflows, which were encountering errors due to incompatibility with the latest Ubuntu LTS version. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Ckk3 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief comment in the workflow file explaining why we're using Ubuntu 22.04 specifically. This will help future maintainers understand the reasoning behind this change and when it might need to be updated.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks Luis!
Description
Our CI started getting some new erros, I've checked that CodSpeed doesn't support Ubuntu 24.04 LTS (lastest LTS).
This PR fixes
Unit tests / 💻 Generate test matrix (pull_request)
andUnit tests / 📈 Benchmarks (pull_request)
workflows by bring back ubuntu 22.04 onBenchmarks
and using a Virtual Enviroment onGenerate Test Matrix
to follow PEP 668 on new ubuntu version.Is also important see that 22.04 LTS will be updated until April 2027
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Summary by Sourcery
Fix CI workflows by switching to Ubuntu 22.04 LTS and updating CodSpeed action to version 3 to resolve compatibility issues.
CI: