Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI with new Ubuntu LTS #198

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Conversation

Ckk3
Copy link
Contributor

@Ckk3 Ckk3 commented Oct 10, 2024

Description

Our CI started getting some new erros, I've checked that CodSpeed doesn't support Ubuntu 24.04 LTS (lastest LTS).
This PR fixes Unit tests / 💻 Generate test matrix (pull_request) and Unit tests / 📈 Benchmarks (pull_request) workflows by bring back ubuntu 22.04 on Benchmarks and using a Virtual Enviroment on Generate Test Matrix to follow PEP 668 on new ubuntu version.

Is also important see that 22.04 LTS will be updated until April 2027

image

image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Summary by Sourcery

Fix CI workflows by switching to Ubuntu 22.04 LTS and updating CodSpeed action to version 3 to resolve compatibility issues.

CI:

  • Update CI workflows to use Ubuntu 22.04 instead of the latest version to ensure compatibility with CodSpeed.

@Ckk3 Ckk3 self-assigned this Oct 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (550c23c) to head (26d137a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   85.32%   85.38%   +0.06%     
==========================================
  Files          16       16              
  Lines        1615     1615              
  Branches      320      128     -192     
==========================================
+ Hits         1378     1379       +1     
  Misses        183      183              
+ Partials       54       53       -1     

Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #198 will not alter performance

Comparing Ckk3:fix-ci-ubuntu-lts (26d137a) with main (550c23c)

Summary

✅ 1 untouched benchmarks

@Ckk3 Ckk3 marked this pull request as ready for review October 10, 2024 23:53
Copy link
Contributor

sourcery-ai bot commented Oct 10, 2024

Reviewer's Guide by Sourcery

This pull request addresses CI issues by updating the Ubuntu version and CodSpeed action in the test workflow. The changes are focused on fixing the "Unit tests / 💻 Generate test matrix" and "Unit tests / 📈 Benchmarks" workflows, which were encountering errors due to incompatibility with the latest Ubuntu LTS version.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update Ubuntu version for CI jobs
  • Change 'runs-on' from 'ubuntu-latest' to 'ubuntu-22.04' for the 'generate-jobs-tests' job
  • Change 'runs-on' from 'ubuntu-latest' to 'ubuntu-22.04' for the 'benchmarks' job
.github/workflows/test.yml
Update CodSpeed action version
  • Update CodSpeed action from v2 to v3 in the 'Run benchmarks' step
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ckk3 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief comment in the workflow file explaining why we're using Ubuntu 22.04 specifically. This will help future maintainers understand the reasoning behind this change and when it might need to be updated.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@mattalbr mattalbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks Luis!

@patrick91 patrick91 merged commit 3397507 into strawberry-graphql:main Oct 12, 2024
14 checks passed
@Ckk3 Ckk3 deleted the fix-ci-ubuntu-lts branch October 13, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants