feat(interface): input type cannot inherit an interface type #1254

scratchmex · 2021-09-15T14:21:04Z

Description

@strawberry.interface
    class SomeInterface:
        some_arg: str

@strawberry.input
class SomeInput(SomeInterface):  # this should throw an error
    another_arg: str

raises the exception InvalidSuperclassInterface:

InvalidSuperclassInterface("An Input class 'SomeInput' cannot inherit from an Interface(s) 'SomeInterface'")

also works when inheriting from multiple interfaces:

InvalidSuperclassInterface("An Input class 'SomeInput' cannot inherit from an Interface(s) 'SomeInterface, SomeOtherInterface'")

Types of Changes

Issues Fixed or Closed by This PR

fix Interfaces should not work with input types #1236

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

codecov · 2021-09-15T14:24:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (279a31d) to head (b76a380).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
+ Coverage   95.04%   95.06%   +0.01%     
==========================================
  Files         514      515       +1     
  Lines       33539    33583      +44     
  Branches     1735     1736       +1     
==========================================
+ Hits        31878    31924      +46     
+ Misses       1379     1377       -2     
  Partials      282      282

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

botberry · 2021-09-15T14:34:34Z

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Starting with this release, Strawberry will throw an error if one of your input
types tries to inherit from one or more interfaces. This new error enforces the
GraphQL specification that input types cannot implement interfaces.

The following code, for example, will now throw an error:

import strawberry


@strawberry.interface
class SomeInterface:
    some_field: str


@strawberry.input
class SomeInput(SomeInterface):
    another_field: int

Here's the tweet text:

🆕 Release (next) is out! Thanks to Ivan Gonzalez for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

tests/schema/test_interface.py

strawberry/exceptions.py

patrick91 · 2021-12-08T22:28:28Z

Hi @scratchmex would you be able to rebase this PR and address the comments made by Bryce? 😊 no worries if not I can't take a look at some point in future :)

fix strawberry-graphql#1236

for more information, see https://pre-commit.ci

codspeed-hq · 2025-06-10T13:50:25Z

CodSpeed Performance Report

Merging #1254 will not alter performance

_{Comparing scratchmex:iss/1236 (b76a380) with main (d999936)}

Summary

✅ 21 untouched benchmarks

DoctorJohn · 2025-06-10T14:15:42Z

@patrick91 I rebased this PR, addressed all feedback, and turned the exception into a StrawberryException.

patrick91

Awesome! Thank you @DoctorJohn! <3

greptile-apps

PR Summary

Added validation to prevent GraphQL input types from inheriting interface types, aligning with GraphQL specification constraints.

Added new InvalidSuperclassInterfaceError in strawberry/exceptions/invalid_superclass_interface.py for proper error handling
Implemented validation in strawberry/types/object_type.py to catch interface inheritance attempts by input types
Added comprehensive error documentation in docs/errors/invalid-superclass-interface.md with clear examples
Added test cases in tests/schema/test_input.py to verify error handling for both single and multiple interface inheritance

_{6 files reviewed, 2 comments}
_{Edit PR Review Bot Settings | Greptile}

RELEASE.md

docs/errors/invalid-superclass-interface.md

old

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

scratchmex force-pushed the iss/1236 branch from dd620d7 to 2d4791b Compare September 15, 2021 14:23

BryceBeagle suggested changes Sep 17, 2021

View reviewed changes

tests/schema/test_interface.py Outdated Show resolved Hide resolved

strawberry/exceptions.py Outdated Show resolved Hide resolved

BryceBeagle previously requested changes Sep 17, 2021

View reviewed changes

strawberry/exceptions.py Outdated Show resolved Hide resolved

scratchmex and others added 2 commits June 10, 2025 15:08

feat(interface): input type cannot inherit an interface type

af16a1f

fix strawberry-graphql#1236

[pre-commit.ci] auto fixes from pre-commit.com hooks

00289d5

for more information, see https://pre-commit.ci

DoctorJohn force-pushed the iss/1236 branch 2 times, most recently from 52822f6 to f566442 Compare June 10, 2025 13:16

Clean up rebase

7651a1c

DoctorJohn force-pushed the iss/1236 branch from c577460 to 7651a1c Compare June 10, 2025 13:18

DoctorJohn added 3 commits June 10, 2025 15:26

Let the exeption class take care of its message

4654c7c

Test exception messages

f24892d

Move tests

debb0e6

DoctorJohn added 2 commits June 10, 2025 16:01

Turn into StrawberryException

ecf9a4c

Add release file

55deb39

botberry added bot:has-release-file bot:release-type-minor labels Jun 10, 2025

DoctorJohn requested a review from patrick91 June 10, 2025 14:15

patrick91 approved these changes Jun 10, 2025

View reviewed changes

greptile-apps bot reviewed Jun 10, 2025

View reviewed changes

RELEASE.md Outdated Show resolved Hide resolved

docs/errors/invalid-superclass-interface.md Outdated Show resolved Hide resolved

Apply suggestions from code review

b76a380

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

patrick91 merged commit fae9c2d into strawberry-graphql:main Jun 10, 2025
102 of 103 checks passed

github-project-automation bot moved this from In progress to Done in Strawberry Monthly Work Jun 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(interface): input type cannot inherit an interface type #1254

feat(interface): input type cannot inherit an interface type #1254

Uh oh!

scratchmex commented Sep 15, 2021 •

edited

Loading

Uh oh!

codecov bot commented Sep 15, 2021 •

edited

Loading

Uh oh!

botberry commented Sep 15, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

patrick91 commented Dec 8, 2021

Uh oh!

codspeed-hq bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

DoctorJohn commented Jun 10, 2025

Uh oh!

patrick91 left a comment

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat(interface): input type cannot inherit an interface type #1254

feat(interface): input type cannot inherit an interface type #1254

Uh oh!

Conversation

scratchmex commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

Uh oh!

codecov bot commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

botberry commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

patrick91 commented Dec 8, 2021

Uh oh!

codspeed-hq bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #1254 will not alter performance

Summary

Uh oh!

DoctorJohn commented Jun 10, 2025

Uh oh!

patrick91 left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

scratchmex commented Sep 15, 2021 •

edited

Loading

codecov bot commented Sep 15, 2021 •

edited

Loading

botberry commented Sep 15, 2021 •

edited

Loading

codspeed-hq bot commented Jun 10, 2025 •

edited

Loading