feat(interface): input type cannot inherit an interface type #1254

scratchmex · 2021-09-15T14:21:04Z

Description

@strawberry.interface
    class SomeInterface:
        some_arg: str

@strawberry.input
class SomeInput(SomeInterface):  # this should throw an error
    another_arg: str

raises the exception InvalidSuperclassInterface:

InvalidSuperclassInterface("An Input class 'SomeInput' cannot inherit from an Interface(s) 'SomeInterface'")

also works when inheriting from multiple interfaces:

InvalidSuperclassInterface("An Input class 'SomeInput' cannot inherit from an Interface(s) 'SomeInterface, SomeOtherInterface'")

Types of Changes

Issues Fixed or Closed by This PR

fix Interfaces should not work with input types #1236

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fix strawberry-graphql#1236

for more information, see https://pre-commit.ci

codecov · 2021-09-15T14:24:29Z

Codecov Report

Merging #1254 (1c74740) into main (a97c96f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1254   +/-   ##
=======================================
  Coverage   97.69%   97.70%           
=======================================
  Files          88       88           
  Lines        3388     3396    +8     
  Branches      498      500    +2     
=======================================
+ Hits         3310     3318    +8     
  Misses         43       43           
  Partials       35       35

botberry · 2021-09-15T14:34:34Z

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to Ivan Gonzalez for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

BryceBeagle · 2021-09-17T22:06:23Z

tests/schema/test_interface.py

@@ -161,3 +162,27 @@ def anime(self) -> Anime:

    assert not result.errors
    assert result.data == {"anime": {"name": "One Piece"}}
+
+
+def test_input_cannot_inherit_from_interface():


Can these tests cover the actual messages of the errors as well?

Do yo know how to catch the exception message with pytest? Or I need to try, catch, save, raise, assert?

You can use

with pytest.raises(ExceptionType) as exc: ... assert exc.value == "something"

Also, note that pytest.raises takes a match argument that may be enough here

Let me have a look, thanks

strawberry/exceptions.py

BryceBeagle · 2021-09-17T22:22:04Z

strawberry/exceptions.py

+
+
+class InvalidSuperclassInterface(Exception):
+    def __init__(self, input_name: str, interface_names=List[str]):


Actually, now that I think about it, wouldn't it be better to take a type and List[type] instead? Let the Exception handle everything related to output?

You are right

patrick91 · 2021-12-08T22:28:28Z

Hi @scratchmex would you be able to rebase this PR and address the comments made by Bryce? 😊 no worries if not I can't take a look at some point in future :)

feat(interface): input type cannot inherit an interface type

2d4791b

fix strawberry-graphql#1236

scratchmex force-pushed the iss/1236 branch from dd620d7 to 2d4791b Compare September 15, 2021 14:23

[pre-commit.ci] auto fixes from pre-commit.com hooks

1c74740

for more information, see https://pre-commit.ci

BryceBeagle suggested changes Sep 17, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(interface): input type cannot inherit an interface type #1254

feat(interface): input type cannot inherit an interface type #1254

scratchmex commented Sep 15, 2021 •

edited

Loading

codecov bot commented Sep 15, 2021 •

edited

Loading

botberry commented Sep 15, 2021 •

edited

Loading

BryceBeagle Sep 17, 2021

scratchmex Sep 17, 2021

BryceBeagle Sep 17, 2021

BryceBeagle Sep 17, 2021

scratchmex Sep 17, 2021

BryceBeagle Sep 17, 2021 •

edited

Loading

scratchmex Sep 17, 2021

patrick91 commented Dec 8, 2021



		class InvalidSuperclassInterface(Exception):
		def __init__(self, input_name: str, interface_names=List[str]):

feat(interface): input type cannot inherit an interface type #1254

Are you sure you want to change the base?

feat(interface): input type cannot inherit an interface type #1254

Conversation

scratchmex commented Sep 15, 2021 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

codecov bot commented Sep 15, 2021 • edited Loading

Codecov Report

botberry commented Sep 15, 2021 • edited Loading

BryceBeagle Sep 17, 2021

Choose a reason for hiding this comment

scratchmex Sep 17, 2021

Choose a reason for hiding this comment

BryceBeagle Sep 17, 2021

Choose a reason for hiding this comment

BryceBeagle Sep 17, 2021

Choose a reason for hiding this comment

scratchmex Sep 17, 2021

Choose a reason for hiding this comment

BryceBeagle Sep 17, 2021 • edited Loading

Choose a reason for hiding this comment

scratchmex Sep 17, 2021

Choose a reason for hiding this comment

patrick91 commented Dec 8, 2021

scratchmex commented Sep 15, 2021 •

edited

Loading

codecov bot commented Sep 15, 2021 •

edited

Loading

botberry commented Sep 15, 2021 •

edited

Loading

BryceBeagle Sep 17, 2021 •

edited

Loading