feat(interface): input type cannot inherit an interface type

[scratchmex]

Description

@strawberry.interface
    class SomeInterface:
        some_arg: str

@strawberry.input
class SomeInput(SomeInterface):  # this should throw an error
    another_arg: str

raises the exception InvalidSuperclassInterface:

InvalidSuperclassInterface("An Input class 'SomeInput' cannot inherit from an Interface(s) 'SomeInterface'")

also works when inheriting from multiple interfaces:

InvalidSuperclassInterface("An Input class 'SomeInput' cannot inherit from an Interface(s) 'SomeInterface, SomeOtherInterface'")

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Documentation

Issues Fixed or Closed by This PR

• fix Interfaces should not work with input types #1236

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[codecov]

Codecov Report

Merging #1254 (1c74740) into main (a97c96f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1254   +/-   ##
=======================================
  Coverage   97.69%   97.70%           
=======================================
  Files          88       88           
  Lines        3388     3396    +8     
  Branches      498      500    +2     
=======================================
+ Hits         3310     3318    +8     
  Misses         43       43           
  Partials       35       35           

[botberry]

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to Ivan Gonzalez for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

[BryceBeagle]

Can these tests cover the actual messages of the errors as well?

[scratchmex]

Do yo know how to catch the exception message with pytest? Or I need to try, catch, save, raise, assert?

[BryceBeagle]

You can use

with pytest.raises(ExceptionType) as exc:
    ...
assert exc.value == "something"

[BryceBeagle]

Also, note that pytest.raises takes a match argument that may be enough here

[scratchmex]

Let me have a look, thanks

[BryceBeagle]

Actually, now that I think about it, wouldn't it be better to take a type and List[type] instead? Let the Exception handle everything related to output?

[scratchmex]

You are right

[patrick91]

Hi @scratchmex would you be able to rebase this PR and address the comments made by Bryce? 😊 no worries if not I can't take a look at some point in future :)