feat: distributor protocol level fees #334

Yolley · 2025-12-15T04:23:29Z

feat: support protocol level airdrop fees;
- for v0 airdrops claim fees will be applied by the sdk;
- for v1 airdrops claim fees are applied by the protocl when calling claimV2;
- all other fees are applied by the protocol always, check getFees and getDefaultFees methods to fetch fees beforehand:
```
// fetch default fees applied if wallet has no partner fees
const defaultFees = await client.getDefaultFees();
// fetch fees for a given wallet
const partnerFees = await client.getFees(wallet.publicKey);
```
feat!: fully migrate to runtime generated anchor client in distributor;
BREAKING CHANGE: sdk no longer exports distributor related classes, they are only exported as types, i.e.:
```
import type { MerkleDistributor, ClaimStatus } from "@streamflow/distributor/solana";
```
feat: add partner oracle to common as it's reused across multiple protocols;
chore: bump anchor to v0.32.1 (no breaking changes for our package);

BREAKING CHANGE: when the protocol is deployed, newDistributor will work only from this SDK version, since it has 2 new accounts added.

github-actions · 2025-12-15T04:57:51Z

Alpha versions of packages are published 📦

PR: #334
Version: 11.0.0-alpha.p334.30f5e22
NPM: https://www.npmjs.com/package/@streamflow/common/v/11.0.0-alpha.p334.30f5e22

tatomir-streamflow · 2025-12-15T13:30:18Z

lerna.json

+  "packages": [
+    "packages/*"
+  ],
+  "version": "11.0.0",


this number is going up faster than the scale in my room during a week at an all inclusive in Turkey

tatomir-streamflow · 2025-12-15T13:37:57Z

packages/common/solana/utils.ts

+/**
+ * Build a partner oracle program without a wallet, just to fetch accounts.
+ */
+export function buildPartnerOracle(connection: Connection): Program<PartnerOracle> {


are we not gonna expose anything else for fee fetching for use in the App? e.g. like we do for vesting

We do expose

And in the common package I just expose the program since it's shared across protocols.

RolginRoman · 2025-12-15T16:46:21Z

lerna.json

+  "packages": [
+    "packages/*"
+  ],
+  "version": "11.0.0",


this number is going up faster than the scale in my room during a week at an all inclusive in Turkey

RolginRoman · 2025-12-15T16:50:43Z

packages/distributor/solana/clients/BaseDistributorClient.ts

+    const feeConfig = await this.getFeeConfig();
+    const nowTs = new BN(Math.trunc(Date.now() / 1000));
+    return (
+      feeConfig.partners.filter((partner) => partner.pubkey.equals(pubkey) && partner.expiryTs.gt(nowTs))[0] ?? null


should it throw if 1+ partners are found? just as a sanity check so we don't forget to clean some stale stuff

It should never happen as the protocol does not allow it when writing fees, but I'll add a throw to mark it as unexpected behavior then.

RolginRoman · 2025-12-15T17:01:58Z

packages/distributor/solana/types.ts

+export type MerkleDistributor = MerkleDistributorAccountTypes["merkleDistributor"];
+
+type IdlInstruction<IDL extends Idl, Name extends IDL["instructions"][number]["name"]> = Extract<
+  IDL["instructions"][number],
+  { name: Name }
+>;
+
+type AccountsOfMethod<M extends keyof Program<MerkleDistributorIDL>["methods"]> = Parameters<
+  ReturnType<Program<MerkleDistributorIDL>["methods"][M]>["accounts"]
+>[0];
+type ArgsOfMethod<M extends keyof Program<MerkleDistributorIDL>["methods"]> = Parameters<
+  Program<MerkleDistributorIDL>["methods"][M]
+>;


a minor, but would be cool to have it globally like in common/anchor for instance since we're increasing anchor inference usage everywhere. Might be useful 🤷‍♂️ but not forcing it.
Just don't want it to be MIA later if a need appear again

Makes sense, tho I put it to common/solana/types for now - as solana package is not exactly a web3js wrapper, it just contains common solana utilities.

RolginRoman · 2025-12-15T17:02:11Z

packages/distributor/solana/constants.ts

+// const [feeOracle] = PublicKey.findProgramAddressSync(
+//   [Buffer.from(b"airdrop_config")],
+//   new PublicKey(PARTNER_ORACLE_PROGRAM_ID[cluster]),
+// );


Just keeping how the address was derived as it's a PDA>

RolginRoman · 2025-12-15T17:02:37Z

packages/distributor/solana/constants.ts

+  [ICluster.Testnet]: "pardoTarcc6HKsPcbXkVycxsJsoN9QEzrdHgVdHAGY3",
+  [ICluster.Local]: "pardoTarcc6HKsPcbXkVycxsJsoN9QEzrdHgVdHAGY3",


Curious do we ever use these two? in all other places as well

Nop, never, prob makes sense to remove the unused clusters are at some point lol, may be in v23

RolginRoman · 2025-12-15T17:07:26Z

packages/distributor/solana/clients/SolanaAlignedDistributorClient.ts

-    const { distributor, mint, clawbackReceiver, tokenProgram, tokenVault, admin } = accounts;
+    const { mint, clawbackReceiver, tokenProgram, admin } = accounts;
+    const distributorKey = getDistributorPda(this.merkleDistributorProgram.programId, pk(accounts.mint), data.version);
+    const tokenVaultKey = getAssociatedTokenAddressSync(pk(mint), pk(admin!), true, pk(tokenProgram));


Is it anchor type inference that is broken and requires to enforce non nullish type or the NewDistributorAccounts helper?

Is it even allowed to call the getNewDistributorInstruction function w/o an admin account?

Suggested change

const tokenVaultKey = getAssociatedTokenAddressSync(pk(mint), pk(admin!), true, pk(tokenProgram));

const tokenVaultKey = getAssociatedTokenAddressSync(pk(mint), pk(admin), true, pk(tokenProgram));

the line below has it too

So, admin is a signer which can be inferred from a transaction by anchor ts - that's why it's an optional account. In our case we always set it tho as we pass signer to all instruction related methods.

Makes sense to wrap it in Required then I guess since admin is the only optional account in this structure.

I'd make types as close to the real life as possible - it is one of ways to make sdks "easier to use for outsiders" (and for us actually too)

…helpers to common, throw on found partners > 1

github-actions · 2026-01-14T12:06:33Z

https://github.com/streamflow-finance/js-sdk/releases/tag/v11.0.0 is released 🎉

feat: distributor protocol level fees

c3d5af1

Yolley requested review from RolginRoman and tatomir-streamflow December 15, 2025 04:23

fix tests

45cbb4e

tatomir-streamflow approved these changes Dec 15, 2025

View reviewed changes

RolginRoman reviewed Dec 15, 2025

View reviewed changes

use required in getNewDistributorInstruction, move idl anchor type …

7c3dbf7

…helpers to common, throw on found partners > 1

RolginRoman approved these changes Dec 16, 2025

View reviewed changes

Yolley added 3 commits December 17, 2025 15:06

fix: pass oracle ids in partial as they are different on devnet

ea83918

commit something to test release

fcf4225

fix: token vault deriviation

30f5e22

Yolley merged commit 7184b12 into master Jan 14, 2026
15 checks passed

Yolley deleted the feat/distributor_protocol_fees branch January 14, 2026 12:02

		[ICluster.Testnet]: "pardoTarcc6HKsPcbXkVycxsJsoN9QEzrdHgVdHAGY3",
		[ICluster.Local]: "pardoTarcc6HKsPcbXkVycxsJsoN9QEzrdHgVdHAGY3",

	const tokenVaultKey = getAssociatedTokenAddressSync(pk(mint), pk(admin!), true, pk(tokenProgram));
	const tokenVaultKey = getAssociatedTokenAddressSync(pk(mint), pk(admin), true, pk(tokenProgram));

feat: distributor protocol level fees #334

feat: distributor protocol level fees #334

Uh oh!

Conversation

Yolley commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yolley Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yolley Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Yolley commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading

Yolley Dec 15, 2025 •

edited

Loading

Yolley Dec 15, 2025 •

edited

Loading