Skip to content

fix: node compat for Dirent sector #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mopsgamer wants to merge 5 commits into from
Closed

fix: node compat for Dirent sector #1222

Mopsgamer wants to merge 5 commits into from
+110 −29

Conversation

@Mopsgamer
Copy link

@Mopsgamer Mopsgamer commented Dec 17, 2025

Fixes #1221

@Mopsgamer Mopsgamer changed the title Fix node compat for Dirent sector fix: node compat for Dirent sector Dec 17, 2025
@Mopsgamer Mopsgamer marked this pull request as ready for review December 17, 2025 15:40
@Mopsgamer Mopsgamer marked this pull request as draft December 17, 2025 16:03
@Mopsgamer
Copy link
Author

Mopsgamer commented Dec 17, 2025

Windows

process.cwd()
C:/Users/user/Documents/GitHub/view-ignored/test

entry.parentPath & path
/Users/user/Documents/GitHub/view-ignored/test

@Mopsgamer
Copy link
Author

Mopsgamer commented Dec 17, 2025

The path issue is a separate problem. I've fixed the issue with Disposable, path, and parentPath, so this PR is ready.

@Mopsgamer Mopsgamer marked this pull request as ready for review December 17, 2025 18:05
@Mopsgamer
style: format
b57e01f 
fix: mimic NodeJS.AsyncIterator
@streamich
Copy link
Owner

streamich commented Jan 15, 2026

Thanks, added!

@streamich streamich closed this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not Disposable, AsyncDisposable IDir

2 participants

@Mopsgamer @streamich