Skip to content

Amending dependencylist in useUpdateEffect.ts for ESLint #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stephenjtyrrell
Copy link

…lint error.

Description

Fix for #947 update to useUpdateEffect.ts to amend the dependencylist to ensure it's always an array, as eslint will complain about it

Type of change

  • [x ] Bug fix (non-breaking change which fixes an issue)

Checklist

  • [x ] Read the Contributing Guide
  • [ x] Perform a code self-review
  • [x ] Comment the code, particularly in hard-to-understand areas
  • [x ] Add documentation
  • [x ] Add hook's story at Storybook
  • [ x] Cover changes with tests
  • [x ] Ensure the test suite passes (yarn test)
  • [x ] Provide 100% tests coverage
  • [ x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • [x ] Make sure types are fine (yarn lint:types).

@stephenjtyrrell stephenjtyrrell changed the title Amending dependencylist to ensure it's always an array, to resolve es… Amending dependencylist in useUpdateEffect.ts for ESLint Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant