fix(dual-output): persist display settings, YT vert fixes, details follow #5397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow * Persist changing displays immediately. Any interaction with displays does not get reflected by any of the streaming service or dual output service views, until some condition occurs (going live most likely). Inconsistency in that could result in bugs. I believe `display` is important enough to be reflected immediately. Validations in DO service that rely on `activeDisplayPlatforms` and `activeDisplayDestinations` might've been looking at stale data. It is also likely that there has been a regression into how the Go Live settings work. * Related to YT, do not attempt to hijack displays when a vertical platform exists, i.e streaming to Twitch vertical + Youtube Both.
gettinToasty
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any interaction with displays does not get reflected by any of the streaming service or dual output service views, until some condition occurs (going live most likely). Inconsistency in that could result in bugs. I believe
displayis important enough to be reflected immediately. Validations in DO service that rely onactiveDisplayPlatformsandactiveDisplayDestinationsmight've been looking at stale data.It is also likely that there has been a regression into how the Go Live settings work.