Skip to content

Fix platform type checking #5962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandboxcoder wants to merge 2 commits into
base: staging
Choose a base branch
from
+6 −2
Open

Fix platform type checking #5962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcb16d1
fix platform type checking
sandboxcoder Jun 5, 2026
a982918
Potential fix for pull request finding
sandboxcoder Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/services/platforms/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,11 @@ export interface IPlatformService {

fetchUserInfo: () => Promise<IUserInfo>;

putChannelInfo: (channelInfo: TStartStreamOptions) => Promise<void>;
/**
* Note: intentionally declared using method syntax (not a function-typed property)
* to avoid strict contravariant parameter checking when platform services implement this interface.
*/
putChannelInfo(channelInfo: TStartStreamOptions): Promise<void>;
Comment thread
sandboxcoder marked this conversation as resolved.

searchGames?: (searchString: string) => Promise<IGame[]>;

Expand Down
2 changes: 1 addition & 1 deletion app/services/platforms/twitch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ export class TwitchService
}).then(json => json.total);
}

async putChannelInfo(settings: Partial<ITwitchStartStreamOptions>): Promise<void> {
async putChannelInfo(settings: ITwitchStartStreamOptions): Promise<void> {
if (settings.tags) {
this.twitchTagsService.actions.setTags(settings.tags);
} else {
Expand Down
Loading