Adding version 2 filters - #6018
Open
sandboxcoder wants to merge 1 commit into
Open
Conversation
BundleMonFiles updated (1)
Unchanged files (3)
Total files change +447B 0% Final result: ✅ View report in BundleMon website ➡️ |
sandboxcoder
force-pushed
the
rno/filterTypes-master
branch
from
July 13, 2026 21:22
5785057 to
17d6350
Compare
sandboxcoder
marked this pull request as ready for review
July 14, 2026 18:09
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the app’s filter allowlist to surface newly added OBS filters and switch several existing filters to their updated “v2” identifiers, while adding missing UI strings for the new filter names.
Changes:
- Switched multiple existing filter type IDs to their
_v2variants (e.g., mask/color/chroma key/noise suppression). - Added allowlisted entries for newly supported filters: Luma Key (v2), Upward Compressor, and 3-Band Equalizer.
- Added English (en-US) i18n strings for the new filter names.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/services/source-filters.ts | Updates the filter type union and the allowlisted filter list to use v2 IDs and include new filter types. |
| app/i18n/en-US/filters.json | Adds en-US translation keys for the newly surfaced filter names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sandboxcoder
force-pushed
the
rno/filterTypes-master
branch
2 times, most recently
from
July 15, 2026 20:42
76bf1be to
1ee3eae
Compare
sandboxcoder
force-pushed
the
rno/filterTypes-master
branch
from
July 15, 2026 20:56
1ee3eae to
37518fd
Compare
sandboxcoder
force-pushed
the
rno/filterTypes-master
branch
from
July 23, 2026 14:53
37518fd to
1dcd01c
Compare
* Add missing filters (Luma Key, 3-Band Eq, and Upward Compressor) * Add version 2 of all known filters that were updated * Remove old version 1 filters. Existing scenes will continue to work automatically. But when user creates a new scene filter, they will receive the updated version.
sandboxcoder
force-pushed
the
rno/filterTypes-master
branch
from
July 23, 2026 14:54
1dcd01c to
d7919df
Compare
michelinewu
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test cases for QA
This PR updates the following filters: Image Mask/Blend, Color Correction, Color Key, Sharpen, Chroma Key, and Noise Suppression
This PR adds Upward Compressor (Audio filter), Luma Key Filter (Video), and 3-Band Equalizer (Audio filter)
Test cases (I tried):
What changed from version 1 to version 2?
Color Correction - v2 adds proper color space negotiation so the filter works correctly in SDR/WCG pipelines without mangling HDR content, whereas v1 blindly assumed GS_RGBA for everything.
Image Mask/Blend- v2 is a precision and color-pipeline upgrade — higher-resolution opacity and proper sRGB/color space awareness
Color Key Filter- v2 is a substantial rework: opacity is redesigned from an alpha-packed color hack into a proper float parameter, brightness scaling is removed, the contrast/brightness ranges are expanded, and the whole render path gains proper color space awareness.
Sharpness - only adds SRGB capability flag
Chroma Key - the chroma key v2 changes are a mirror of the color key v2 changes — opacity redesigned from an alpha-packed color hack to a proper float, brightness scaling removed, expanded ranges, and full color space pipeline awareness added.
Noise Suppression (Audio) - v2 promotes RNN (Recurrent Neural Network) noise suppression as the preferred default when available, rather than only falling back to it when Speex isn't present.
New filters that this PR exposes
Luma Key Filter:
The luma key filter makes pixels transparent based on their brightness (luminance) rather than a specific color. It exposes four parameters:
For example, with default settings (luma_min=0.0, luma_max=1.0, no smoothing), nothing is keyed. If you set luma_min=0.5, pixels darker than 50% brightness become transparent — useful for removing black backgrounds or applying overlays that blend based on brightness
rather than color.
It's commonly used with white/black backgrounds or as a way to composite elements where a color-based chroma key wouldn't work.
Upwards Compressor: The upward compressor is an audio dynamics filter that boosts quiet sounds up toward a threshold, as opposed to a traditional (downward) compressor which turns loud sounds down.
How it works:
Parameters:
Practical use: leveling out a quiet speaker or microphone so soft parts of speech become more audible without turning up the overall volume
3 Band Equalizer: It's a simple 3-band equalizer audio filter. It splits the audio signal into three frequency bands and lets you boost or cut each by ±20 dB: