Remove Dlive. - #6060
Open
michelinewu wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the sunsetted “extra platform” DLive from Streamlabs Desktop’s onboarding/login surfaces and shared UI helpers, ensuring it can’t be reintroduced via the narrowed extra-platform union type.
Changes:
- Removed DLive UI entry points from onboarding (login button/icon + RTMP ingest/help definition) and updated the onboarding e2e assertion accordingly.
- Removed DLive from shared UI assets/styling and the Shared Components Library example.
- Narrowed
TExtraPlatformto only'nimotv'across onboarding components so the type system rejects any future DLive usage.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/components-react/pages/onboarding/ExtraPlatformConnect.tsx | Removes DLive ingest/help definition and narrows props to 'nimotv' | undefined. |
| app/components-react/pages/onboarding/Connect.tsx | Removes the DLive extra-platform entry and narrows TExtraPlatform to 'nimotv'. |
| app/components-react/modals/onboarding/Login.tsx | Removes DLive from extraPlatforms and narrows TExtraPlatform. |
| app/components-react/shared/PlatformLogo.tsx | Removes DLive from the prop union and icon mapping. |
| app/components-react/shared/PlatformLogo.m.less | Removes the .dlive logo background rule. |
| app/services/platforms/index.ts | Removes dlive from platformLabels mapping. |
| app/styles/buttons.less | Removes the .button--dlive styling. |
| app/components-react/windows/sharedComponentsLibrary/SharedComponentsLibrary.tsx | Removes the DLive logo example entry. |
| test/regular/onboarding.ts | Removes the DLive platform icon assertion from onboarding e2e. |
| media/images/platforms/dlive-logo.png | Deleted DLive logo asset. |
| media/images/platforms/dlive-logo-small.png | Deleted small DLive logo asset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gettinToasty
approved these changes
Jul 29, 2026
BundleMonFiles updated (1)
Unchanged files (3)
Total files change -1.17KB -0.01% Final result: ✅ View report in BundleMon website ➡️ |
sandboxcoder
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove DLive
Remove sunsetted platform DLive.
Issue
DLive was never a true platform integration. It had no service class, and no entry in
EPlatform,TPlatform,platformList, orgetPlatformService. It was an "extra platform": a hardcoded RTMP ingest shortcut shown on the onboarding loginscreen next to Nimo.TV.
Changes
Removed every reference to DLive: the onboarding entry point, the ingest definition, the logo/label/styling, the shared-component-library example, and the e2e assertion. The two DLive image assets are deleted.
TExtraPlatformnarrows from'dlive' | 'nimotv'to'nimotv'in all three places it is declared, so the type system now rejects any attempt to reintroduce DLive through these components. Nimo.TV, the other extra platform, is deliberately left in place.Files changed
app/components-react/pages/onboarding/ExtraPlatformConnect.tsx'nimotv' | undefinedapp/components-react/pages/onboarding/Connect.tsxTExtraPlatformnarrowedapp/components-react/modals/onboarding/Login.tsxextraPlatforms;TExtraPlatformnarrowedapp/components-react/shared/PlatformLogo.tsxapp/components-react/shared/PlatformLogo.m.less.dlivebackground ruleapp/services/platforms/index.tsdlivefromplatformLabelsapp/styles/buttons.less.button--dliveapp/components-react/windows/sharedComponentsLibrary/SharedComponentsLibrary.tsxtest/regular/onboarding.tsplatform-icon-button-dliveassertionmedia/images/platforms/dlive-logo.pngmedia/images/platforms/dlive-logo-small.png11 files, +6 / −41.
Incidental find:
ExtraPlatformConnectdeclaredicon: 'dlive-white.png', a file that does not exist in the repo. The field was never read — the component renders<PlatformLogo>instead — so it was dead either way. It is gone with the rest.Performance Implications
None. No runtime code paths change for any remaining platform. Marginally smaller bundle
and one fewer image shipped (~282 KB of PNG assets removed).