build: package the py.typed marker - #65
Merged
Merged
Conversation
Ship the PEP 561 marker in both wheel and source distributions so type checkers recognize the package's inline typing. Exempt .typed files from the license-header check so the standard empty marker can pass pre-commit. Co-authored-by: Bulat Shelkhonov <shelbulat@mail.ru> Co-authored-by: Cursor <cursoragent@cursor.com>
Keep downstream type checkers from surfacing internal errors once the package ships a PEP 561 marker. This preserves a useful public signature for streamlit_bokeh() while loosening the internal Streamlit component plumbing across the v1 and v2 registration paths. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py.typedmarker and package it in both wheel and sdist artifacts so type checkers recognizestreamlit-bokehas a typed package.typedfiles from the license-header check so the standard empty marker file passes repo hooksstreamlit_bokehso downstreammypyusers see the publicstreamlit_bokeh()signature without internal package errorsTest plan
pre-commit run --all-filespython -m buildmypysmoke test against a small consumer script