Skip to content

feat: add capacity type node groups to allow for spot nodes #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dpappa
Copy link
Member

@dpappa dpappa commented Jan 31, 2025

Motivation

This PR will allow us to specify the capacity type, which is typically "on-demand". There are some instances where we would like to make node groups spot for cost savings on lower level environments.

Modifications

I've exposed the node_pool_capacity_type which allows modification to the capacity types of all node groups created via the eks-managed-node-group submodule.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@dpappa dpappa self-assigned this Jan 31, 2025
@dpappa dpappa requested a review from a team as a code owner January 31, 2025 15:59
Copy link
Contributor

@dpappa:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jan 31, 2025
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Jan 31, 2025
Copy link
Contributor

@dpappa:Thanks for providing doc info!

@github-actions github-actions bot added doc-required This pr needs a document and removed doc-required This pr needs a document labels Jan 31, 2025
Copy link
Contributor

@dpappa:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description and removed doc-info-missing This pr needs to mark a document option in description labels Jan 31, 2025
Copy link
Contributor

@dpappa:Thanks for providing doc info!

@github-actions github-actions bot added the doc This pr contains a document label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc This pr contains a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant