fix region name for volume resource #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the region naming for volume resources by updating how the region is set and read in the resource's create, read, and update functions.
- Updated create function to set the region in the volume specification.
- Adjusted read function to retrieve the region from the canonical field.
- Modified update function to assign the region value consistently.
| volume.Spec.Bucket = bucket | ||
| volume.Spec.Path = path | ||
| volume.Spec.Region = region | ||
| volume.Spec.AWS.Region = region |
There was a problem hiding this comment.
The region is being assigned to both volume.Spec.Region and volume.Spec.AWS.Region. If volume.Spec.Region is the canonical field, consider removing the assignment to volume.Spec.AWS.Region to avoid redundancy and potential confusion.
Suggested change
| volume.Spec.AWS.Region = region |
tuteng
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.