Add annotation during destroy to allow deletion #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jung-kim
previously approved these changes
Jul 30, 2025
jung-kim
reviewed
Aug 6, 2025
Comment on lines
478
to
481
| if err != nil { | ||
| //If we can't find the CE, just return, as the CE is already deleted | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Sorry I should have been more specific, more like this. This is the pattern we use alot in apiserver
if err != nil {
if apierror.IsNotFound(err) {
return nil, nil
}
return nil, err
}
jung-kim
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #127