Skip to content

Conversation

@jbeard4
Copy link
Member

@jbeard4 jbeard4 commented Dec 31, 2025

Summary

  • configure Sequelize to keep the default timezone so initialization avoids SET TIME ZONE
  • disable client_min_messages initialization to reduce session pinning in RDS Proxy

Testing

  • not run (not requested)

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/config.js Outdated
Comment on lines 23 to 24
dialectOptions: {
clientMinMessages: false, // avoid issuing SET client_min_messages

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Invalid client_min_messages value may block connections

Postgres accepts only log-level strings for client_min_messages (e.g., warning, notice); setting dialectOptions.clientMinMessages to the boolean false means Sequelize will issue SET client_min_messages TO false during connection setup, which Postgres rejects with invalid value for parameter "client_min_messages": "false". When this runs against a Postgres backend, the app will fail to acquire a database connection instead of simply avoiding session pinning. Consider omitting the option or using a valid log level string.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants