Pills should reflect second level filter selections #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rovack
reviewed
Jan 24, 2025
Member
Rovack
left a comment
Rovack
left a comment
There was a problem hiding this comment.
Code looks great to me. Only left a few really minor comments.
Member
There was a problem hiding this comment.
Wondering here too if all these .idea files are supposed to be committed. They're usually gitignored, aren't they?
Collaborator
Author
There was a problem hiding this comment.
These idea files were accidentally committed. Yeah, they are gitignores. The ".idea" folder is already added to the gitignore file. But don't know how they were added when I used "git add ."
| )} | ||
| </Link> | ||
| ) : undefined} | ||
| {/* getUrlWithNewFilterParameter */} |
Collaborator
Author
There was a problem hiding this comment.
Yes. I left this here for reference on how we previously handled this section.
Contributor
|
@shakilhossain1 pls reply to the comments |
shakilhossain1
force-pushed
the
shakil/filters-header
branch
from
c315c0b to
7090dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60