Fix documents required #434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the rendering of document requirements in the Service component by changing the conditional logic to display "No documents required" instead of "No proofs required".
- Updated the conditional check for document requirement text.
- Modified the output message to align with the updated condition.
Comment on lines
+380
to
+381
| req === "No documents required" | ||
| ? "No documents required" |
There was a problem hiding this comment.
[nitpick] Consider extracting the literal string 'No documents required' into a constant to avoid duplication and ensure consistency in future updates.
Suggested change
| req === "No documents required" | |
| ? "No documents required" | |
| req === NO_DOCUMENTS_REQUIRED | |
| ? NO_DOCUMENTS_REQUIRED |
Member
|
This streetlives-web branch was created from age branch, so let's get the age change in first, then return to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.