-
-
Notifications
You must be signed in to change notification settings - Fork 257
refactor: consolidate English shared -ise words into shared-additional-words-ise.txt
#4397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ccoVeille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jason3S I dropped comment to ask you to specificaly looks at them
-ise words into shared-additional-words-ise.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the hard work.
I made this into a refactor instead of a feat. The idea is that the consumer of these dictionaries do not care about how the source is arranged if the final dictionary content is not changed.
|
Note: To build the dictionaries locally, just use: It will build any files that need to be updated. |
|
It is necessary to build the shared dictionary. To do that, add the following to:
diff --git a/dictionaries/en_shared/cspell-tools.config.yaml b/dictionaries/en_shared/cspell-tools.config.yaml
index 18f3ae1c..4eeba553 100644
--- a/dictionaries/en_shared/cspell-tools.config.yaml
+++ b/dictionaries/en_shared/cspell-tools.config.yaml
@@ -11,6 +11,16 @@ targets:
compress: false
excludeWordsFrom:
- src/exclude-words.txt
+ - name: 'shared-additional-words-ise'
+ sources:
+ - filename: src/shared-additional-words-ise.txt
+ split: true
+ format: plaintext
+ targetDirectory: './dict'
+ generateNonStrict: false
+ compress: false
+ excludeWordsFrom:
+ - src/exclude-words.txt
- name: exclude-words
sources:
- filename: src/exclude-words.txt |
Note: Due to the fork settings, I cannot submit change / updates. To apply the diff:
This should update the file for you. It is needed otherwise the dictionaries will not build. |
Thank you. I didn't see it. I'll look. |
This will help us to maintain non American English words in the dictionaries.
|
It should be OK now. The PR can be reviewed. |
|
Yes, it is now building! Thank you. |

Add/Fix Dictionary
Dictionary: _all English dictionary`
Description
References
Checklist
fix:- for minor changes like adding words or fixing spelling issues.feat:- for a significant change like adding a whole new set of words to a dictionary.feat!:- for breaking changes, like file format or licensing changes.chore:- for changes that do not impact the content of dictionaries.