Skip to content

editor: skip markdown clipboard parsing if markdown shortcuts is disabled #8604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
01zulfi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

editor: skip markdown clipboard parsing if markdown shortcuts is disabled #8604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/editor/src/extensions/clipboard/clipboard-text-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ export function clipboardTextParser(
text: string,
$context: ResolvedPos,
plain: boolean,
view: EditorView
view: EditorView,
parseMarkdownOnPaste = true
): Slice {
if (!plain && isProbablyMarkdown(text)) {
if (!plain && parseMarkdownOnPaste && isProbablyMarkdown(text)) {
Copy link
Contributor Author

@01zulfi 01zulfi Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated comment: plain is true when content is pasted via ctrl+shift+v but false if pasted view right click > paste as plain text. I haven't found any answer for this yet

Copy link
Contributor

@thecodrr thecodrr Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plain is set by prosemirror I think. Might be worth investigating.

const node = ClipboardDOMParser.fromSchema(view.state.schema).parse(
new DOMParser().parseFromString(
markdowntoHTML(text, { allowDangerousHtml: false }),
Expand Down
15 changes: 14 additions & 1 deletion packages/editor/src/extensions/clipboard/clipboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ import { EditorView } from "prosemirror-view";
export const Clipboard = Extension.create({
name: "clipboard",

addOptions() {
return {
parseMarkdownOnPaste: true
};
},

addProseMirrorPlugins() {
return [
new Plugin({
Expand All @@ -40,7 +46,14 @@ export const Clipboard = Extension.create({
this.editor.schema
),
transformCopied,
clipboardTextParser,
clipboardTextParser: (text, $context, plain, view) =>
clipboardTextParser(
text,
$context,
plain,
view,
this.options.parseMarkdownOnPaste
),
clipboardTextSerializer
}
})
Expand Down
4 changes: 3 additions & 1 deletion packages/editor/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,9 @@ const useTiptap = (
allowTableNodeSelection: true,
cellMinWidth: 50
}),
Clipboard,
Clipboard.configure({
parseMarkdownOnPaste: options.enableInputRules
}),
TableRow,
TableCell,
TableHeader,
Expand Down
Loading