core: Duplicating a note should copy all the flags. #9250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off by: Chloe Oletto <NeedsChloesure@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicating an item should copy the item flags. Duplication implies you are making an identical copy, and not copying the item flags means that this item isn't an exact duplicate.
This issue also causes a usability UX problem when duplicating an item that is archived, because it won't show up in the archived section, which may confuse users and cause them to create multiple duplicates of the same note as they could think that the first time the action did not occur. They would have to notice that the note count (in the regular notes section) has indeed gone up.
Other notes: Expiring note expiry dates aren't copied over, but I think that's a good thing as users may forget to change (or remove) it otherwise.