Document how to dynamically update the allowlist of brokers #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimaison
commented
May 26, 2025
| --alter --entity-type brokers --entity-default \ | ||
| --add-config "prometheus.metrics.reporter.allowlist=[kafka_controller.*,kafka_log.*]" | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Should we also include sample Java code demonstrating the Admin API usage?
There was a problem hiding this comment.
I've added an example
Signed-off-by: Mickael Maison <[email protected]>
PaulRMellor
approved these changes
May 29, 2025
| --alter --entity-type brokers --entity-default \ | ||
| --add-config "prometheus.metrics.reporter.allowlist=[kafka_controller.*,kafka_log.*]" | ||
| ``` | ||
|
|
Co-authored-by: PaulRMellor <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
Co-authored-by: PaulRMellor <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
Signed-off-by: Mickael Maison <[email protected]>
mimaison
commented
Jun 3, 2025
| @@ -113,7 +113,7 @@ public void testReconfigureAllowlist() throws Exception { | |||
|
|
|||
| try (Admin admin = Admin.create(Map.of(AdminClientConfig.BOOTSTRAP_SERVERS_CONFIG, broker.getBootstrapServers()))) { | |||
| admin.incrementalAlterConfigs(Map.of( | |||
| new ConfigResource(ConfigResource.Type.BROKER, String.valueOf(NODE_ID)), | |||
| new ConfigResource(ConfigResource.Type.BROKER, ""), | |||
There was a problem hiding this comment.
Adjusted the code in the test to match the example. Using empty string applies the update to all brokers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84