oath-client handler class refactoring #226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clazz Signed-off-by: Berk Delibalta <[email protected]>
…config object for one entry Signed-off-by: Berk Delibalta <[email protected]>
Signed-off-by: Berk Delibalta <[email protected]>
…mports in ClienUtils Signed-off-by: Berk Delibalta <[email protected]>
…1 tests and added javadocs whearas necessary for java17 test Signed-off-by: Berk Delibalta <[email protected]>
Signed-off-by: Berk Delibalta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the code for better understandability, maintainability and testability by separating concerns via delegating some functions to other classes and injecting them in the main handler class.
Simplified the code logic whereas possible without hurting the general structure much.
Note: Would be great if we could utilise Java 17 to start taking advantage of new "switch" for a more data oriented approach instead of if-else.