Fix Keycloak urls in example to work with recent versions of Keycloak #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Strukelj <[email protected]>
scholzj
reviewed
Nov 20, 2024
| @@ -91,5 +91,5 @@ log4j.logger.state.change.logger=TRACE, stateChangeAppender | |||
| log4j.additivity.state.change.logger=false | |||
|
|
|||
| # Access denials are logged at INFO level, change to DEBUG to also log allowed accesses | |||
| log4j.logger.kafka.authorizer.logger=INFO, authorizerAppender | |||
| log4j.logger.kafka.authorizer.logger=DEBUG, authorizerAppender | |||
There was a problem hiding this comment.
It was intentional but this reminds me now of having once issues with Travis CI failing due to log files becoming to big, and this might cause that issue to appear again.
There was a problem hiding this comment.
I guess we can wait and see if CI fails, and if it does revert this change.
|
I added a better (hopefully) description. |
|
Travis is failing for |
scholzj
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OAuth2 endpoints in Keycloak examples still use the urls as they were by default on legacy versions of Keycloak (e.g. 19.0.3-legacy). In the testsuite we moved some time ago to start using recent versions of Keycloak (e.g. 23.0.x) and we adjusted the OAuth2 endpoint urls there to use the default structure compatible with recent Keycloak releases.
Specifically, where before the url would look like:
https://localhost:8443/auth/realms/demoit now looks like:
https://localhost:8443/realms/demo