Skip to content

Remove Java 8 support + move the testsuite from Travis to Azure #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2025

Conversation

mstruk
Copy link
Contributor

@mstruk mstruk commented Mar 4, 2025

This PR implements strimzi/proposals#151 for OAuth repo.

It also removes Java 8 support. The released Maven artifacts will now be built with Java 11.

@mstruk mstruk added this to the 0.16.0 milestone Mar 4, 2025
@mstruk mstruk marked this pull request as ready for review March 5, 2025 09:47
@mstruk mstruk requested review from ppatierno and Frawless March 5, 2025 09:48
echo "Usage: DISABLED=false ./build.sh"
exit 0
fi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why aren't we just removing the .travis file? Didn't this proposal have the purpose of doing that? https://github.com/strimzi/proposals/blob/main/099-drop-travis-ci-and-testing-for-ppc-and-s390x.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that as well yes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Frawless was it your intention as per the proposal you wrote?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, .travis shoudl be removed.

@mstruk
Copy link
Contributor Author

mstruk commented Mar 5, 2025

Someone with permissions will have to go into project Settings and turn off Travis CI integration.
With .travis/build.sh gone the Travis CI check will now always fail.

@ppatierno
Copy link
Member

ppatierno commented Mar 5, 2025

Someone with permissions will have to go into project Settings and turn off Travis CI integration.
With .travis/build.sh gone the Travis CI check will now always fail.

I deleted the webhook which was notifying Travis CI but maybe it's too late for this PR and the Travis CI failure will stay?
I have also removed the oauth repo from the Travis CI app (which is installed at global level within Strimzi org)

@mstruk mstruk changed the title Enable running the testsuite on Azure / remove running on Travis Remove Java 8 support + move the testsuite from Travis to Azure Mar 5, 2025
@mstruk
Copy link
Contributor Author

mstruk commented Mar 5, 2025

I deleted the webhook which was notifying Travis CI but maybe it's too late for this PR and the Travis CI failure will stay? I have also removed the oauth repo from the Travis CI app (which is installed at global level within Strimzi org)

I can push a cosmetic change, and we'll see.

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@mstruk mstruk merged commit a4b7a7a into strimzi:main Mar 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants