-
Notifications
You must be signed in to change notification settings - Fork 95
Remove Java 8 support + move the testsuite from Travis to Azure #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
echo "Usage: DISABLED=false ./build.sh" | ||
exit 0 | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why aren't we just removing the .travis
file? Didn't this proposal have the purpose of doing that? https://github.com/strimzi/proposals/blob/main/099-drop-travis-ci-and-testing-for-ppc-and-s390x.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that as well yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Frawless was it your intention as per the proposal you wrote?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, .travis
shoudl be removed.
Signed-off-by: Marko Strukelj <[email protected]>
Someone with permissions will have to go into project Settings and turn off Travis CI integration. |
I deleted the webhook which was notifying Travis CI but maybe it's too late for this PR and the Travis CI failure will stay? |
I can push a cosmetic change, and we'll see. |
Signed-off-by: Marko Strukelj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
This PR implements strimzi/proposals#151 for OAuth repo.
It also removes Java 8 support. The released Maven artifacts will now be built with Java 11.