Skip to content

A test and a fix for #260 - Int overrun parsing EXP and IAT from JWT token #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

mstruk
Copy link
Contributor

@mstruk mstruk commented Mar 24, 2025

This PR fixes #260

@mstruk mstruk force-pushed the int32_overrun_fix branch from 542441c to 6a75d5b Compare March 24, 2025 19:39
@mstruk mstruk added this to the 0.16.0 milestone Mar 24, 2025
@ppatierno ppatierno requested a review from a team March 24, 2025 22:45
@ppatierno
Copy link
Member

@mstruk can you please update the PR description with something like (at least) "This PR fixes #260".
It will help GitHub to close the issue automatically when the PR is merge as well.

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't pretend to be the expert here but it seems to look good to me.

Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert, but LGTM. Thanks

@mstruk mstruk merged commit a7b81eb into strimzi:main Apr 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Possible overflow parsing timestamps in oauth JWTs as 32 bit int.
3 participants