-
Notifications
You must be signed in to change notification settings - Fork 95
Remove any Zookeeper specific functionality and dependencies #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a pass. Of course 99 files changed is a lot but mostly related to Java 11 removal and ZooKeeper (a lot within the testsuite). I just left a nit but overall LGTM, assuming it works :-)
...eycloak-authorizer/src/main/java/io/strimzi/kafka/oauth/server/authorizer/Configuration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
Signed-off-by: Marko Strukelj <[email protected]>
kafka-oauth-keycloak-authorizer
remain Java 11 bytecode compatibleKeycloakAuthorizer
functionality to delegate to Kafka ACL authorizer now only works in KRaft mode