Add support for the Strimzi Metrics Reporter to Kafka brokers/controllers components #11051

OwenCorrigan76 · 2025-01-16T17:14:53Z

Type of change

Enhancement / new feature

Description

This patch adds support for the Strimzi Metrics Reporter to Kafka brokers/controllers components as described by the following proposal:

https://github.com/strimzi/proposals/blob/main/064-prometheus-metrics-reporter.md

Related to #10753

Support for Kafka Connect and MirrorMaker2 and Strimzi Kafka Bridge will be added in subsequent PRs.

CEL Validation has been added to the MetricsConfig and CruiseControl API in this PR.
CEL Validation was introduced to Strimzi in this PR:
#11068

We won’t initially support the CruiseControl component. To make it work, CC should be changed to expose metrics through its HTTP endpoint.

Checklist

Write tests
Make sure all tests pass
Update documentation
Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
Reference relevant issue(s) and close them after merging
Update CHANGELOG.md

scholzj

I left some comments after an initial pass. You should also update the names / description / CHANGELOG to make it clear what this really does. Kafka compoenents are brokers/controllers, Connect and MM2. You add this only for brokers/controllers. It should be clear from the CHANGELOG and PR name / desc.

CHANGELOG.md

packaging/examples/metrics/grafana-dashboards/strimzi-kafka.json

packaging/examples/metrics/grafana-dashboards/strimzi-kraft.json

api/src/main/java/io/strimzi/api/kafka/model/kafka/KafkaClusterSpec.java

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/ConfigMapUtils.java

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/CruiseControl.java

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java

...perator/src/main/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilder.java

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java

OwenCorrigan76 · 2025-01-17T12:01:44Z

@scholzj I am currently working on the changes I did not comment on yet.

CHANGELOG.md

api/src/main/java/io/strimzi/api/kafka/model/common/metrics/StrimziMetricsReporterValues.java

api/src/main/java/io/strimzi/api/kafka/model/common/metrics/JmxPrometheusExporterMetrics.java

scholzj

I left some more comments. There also seem to be many unaddressed older comments. Not sure if that was intentional or not at this point.

CHANGELOG.md

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/CruiseControl.java

...tor/src/main/java/io/strimzi/operator/cluster/model/metrics/StrimziMetricsReporterModel.java

...ator/src/main/java/io/strimzi/operator/cluster/model/metrics/JmxPrometheusExporterModel.java

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/metrics/MetricsModel.java

packaging/examples/metrics/reporter/kafka-metrics.yaml

fvaleri · 2025-02-17T07:56:46Z

There also seem to be many unaddressed older comments. Not sure if that was intentional or not at this point.

@scholzj I'm supporting Owen with this feature. He is working on and will eventually address all comments.

OwenCorrigan76 · 2025-02-17T11:15:26Z

@scholzj I know progress is going quite slowly. I will address the previous comments shortly. I'm currently working on the CEL validation. When that is committed, I'll go back and tackle the older comments and work through them.

scholzj · 2025-02-17T13:24:54Z

@scholzj I know progress is going quite slowly. I will address the previous comments shortly. I'm currently working on the CEL validation. When that is committed, I'll go back and tackle the older comments and work through them.

No worries Owen, I was just unsure what the expected state is. I did not intend to put any pressure on your. Sorry.

OwenCorrigan76 · 2025-02-25T11:02:31Z

The build failed with the following tests:
io.strimzi.api.kafka.model.kafka.KafkaCrdIT.testKafkaWithNullMaintenance
Currently investigating why.

fvaleri

Hi @OwenCorrigan76, we still need to do some changes and address the remaining comments, but it works fine.

For the KafkaCrdIT.testKafkaWithNullMaintenance failure, I think we simply need to update the expected error messages removing the invalid: prefix. Now, you get invalid: [, rather than invalid: . With CEL validation rules, we get the additional error message "validation rules were not checked".

api/src/main/java/io/strimzi/api/kafka/model/kafka/KafkaClusterSpec.java

api/src/main/java/io/strimzi/api/kafka/model/common/metrics/JmxPrometheusExporterMetrics.java

api/src/main/java/io/strimzi/api/kafka/model/common/metrics/StrimziMetricsReporterValues.java

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/CruiseControl.java

...perator/src/main/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilder.java

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaConnectCluster.java

docker-images/kafka-based/kafka/scripts/kafka_connect_run.sh

docker-images/kafka-based/kafka/scripts/kafka_run.sh

packaging/examples/metrics/strimzi-metrics-reporter/kafka-metrics.yaml

fvaleri

@OwenCorrigan76 I was wrong on the "Unsupported metrics type", please correct.

api/src/main/java/io/strimzi/api/kafka/model/common/metrics/JmxPrometheusExporterMetrics.java

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaConnectCluster.java

...perator/src/main/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilder.java

fvaleri

Changes looks good to me for now, but we still have some comments to address.

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Signed-off-by: OwenCorrigan76 <[email protected]>

Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Signed-off-by: OwenCorrigan76 <[email protected]>

… listener.enabed=true Signed-off-by: OwenCorrigan76 <[email protected]>

katheris · 2025-04-10T13:41:22Z

/azp run regression

azure-pipelines · 2025-04-10T13:41:35Z

Azure Pipelines successfully started running 1 pipeline(s).

katheris

One tiny nit, but otherwise this looks good to me

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java

katheris · 2025-04-10T13:55:25Z

@scholzj I see you have a requested change on this PR, has it been addressed?

…irectory Signed-off-by: OwenCorrigan76 <[email protected]>

scholzj · 2025-04-11T11:20:02Z

api/src/main/java/io/strimzi/api/kafka/model/common/metrics/StrimziMetricsReporterValues.java

+    private List<String> allowList;
+    private Map<String, Object> additionalProperties;
+
+    @Description("A comma separated list of regex patterns to specify the metrics to collect.")


It is a Java / YAML list ... so the description is probably wrong? (I.t. it is not a String with comma separated list)

scholzj · 2025-04-11T11:29:29Z

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/ConfigMapUtils.java

+        if (model instanceof SupportsMetrics supportsMetrics && supportsMetrics.metrics() instanceof JmxPrometheusExporterModel) {
+            String parseResult = ((JmxPrometheusExporterModel) supportsMetrics.metrics()).metricsJson(reconciliation, metricsAndLogging.metricsCm());


Can't you do something like this:

Suggested change

if (model instanceof SupportsMetrics supportsMetrics && supportsMetrics.metrics() instanceof JmxPrometheusExporterModel) {

String parseResult = ((JmxPrometheusExporterModel) supportsMetrics.metrics()).metricsJson(reconciliation, metricsAndLogging.metricsCm());

if (model instanceof SupportsMetrics supportsMetrics && supportsMetrics.metrics() instanceof JmxPrometheusExporterModel jmxMetrics) {

String parseResult = jmxMetrics.metricsJson(reconciliation, metricsAndLogging.metricsCm());

scholzj · 2025-04-11T11:31:17Z

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/CruiseControl.java

@@ -105,7 +109,7 @@ public class CruiseControl extends AbstractModel implements SupportsMetrics, Sup

    // Configuration defaults
    protected static final boolean DEFAULT_CRUISE_CONTROL_METRICS_ENABLED = false;


Should it be now DEFAULT_CRUISE_CONTROL_JMX_EXPORTER_METRICS_ENABLED? You renamed one variable but not the other. Might make sense to keep them consistent, or?

Actually, on a second look ... this seems like something to be removed. It is used only in the test as the default value there. But it is not the default value anymore. So I guess it should be deleted and if needed the test can just use false.

I also think this is not needed anymore and can be removed.

scholzj · 2025-04-11T11:41:59Z

...perator/src/main/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilder.java

+        createConfigIfMissing(userConfig, "config.providers.strimzienv.class", "org.apache.kafka.common.config.provider.EnvVarConfigProvider");
+        createConfigIfMissing(userConfig, "config.providers.strimzienv.param.allowlist.pattern", ".*");

        if (node.broker()) {
            // File and Directory providers are used only on broker nodes
-            writer.println("config.providers.strimzifile.class=org.apache.kafka.common.config.provider.FileConfigProvider");
-            writer.println("config.providers.strimzifile.param.allowed.paths=/opt/kafka");
-            writer.println("config.providers.strimzidir.class=org.apache.kafka.common.config.provider.DirectoryConfigProvider");
-            writer.println("config.providers.strimzidir.param.allowed.paths=/opt/kafka");
+            createConfigIfMissing(userConfig, "config.providers.strimzifile.class", "org.apache.kafka.common.config.provider.FileConfigProvider");
+            createConfigIfMissing(userConfig, "config.providers.strimzifile.param.allowed.paths", "/opt/kafka");
+            createConfigIfMissing(userConfig, "config.providers.strimzidir.class", "org.apache.kafka.common.config.provider.DirectoryConfigProvider");
+            createConfigIfMissing(userConfig, "config.providers.strimzidir.param.allowed.paths", "/opt/kafka");


The options we use HAVE TO be configured our way. So these cannot be set if they are missing. If you are afraid that users would decide to use the providers with the same names as we use them, that is a far point, but you need to throw an InvalidConfiguration exception in such a case. (Or for example overwrite them with our values - but not keep the original values from the user)

This is just a refactoring, the behavior of configProviders doesn't change. The intention is to avoid code duplication, as this config manipulation logic is reused by the new methods.

Initially we went with the override approach, but after further inspection, we found that the original code wasn't producing any override when the user configuration had the same config providers' aliases. This is because the original user config is written last in the Kafka configuration file and wins over the Strimzi one.

Example:

$ kubectl get k my-cluster -o yaml | yq '.spec.kafka.config' config.providers: strimzienv config.providers.strimzienv.class: org.apache.kafka.common.config.provider.EnvVarConfigProvider config.providers.strimzienv.param.allowlist.pattern: test.* $ kubectl exec my-cluster-broker-0 -- cat /tmp/strimzi.properties ########## # Config providers ########## # Configuration providers configured by the user and by Strimzi config.providers=strimzienv,strimzienv,strimzifile,strimzidir config.providers.strimzienv.class=org.apache.kafka.common.config.provider.EnvVarConfigProvider config.providers.strimzienv.param.allowlist.pattern=.* config.providers.strimzifile.class=org.apache.kafka.common.config.provider.FileConfigProvider config.providers.strimzifile.param.allowed.paths=/opt/kafka config.providers.strimzidir.class=org.apache.kafka.common.config.provider.DirectoryConfigProvider config.providers.strimzidir.param.allowed.paths=/opt/kafka ########## # User provided configuration ########## config.providers.strimzienv.class=org.apache.kafka.common.config.provider.EnvVarConfigProvider config.providers.strimzienv.param.allowlist.pattern=test.*

If you are afraid that users would decide to use the providers with the same names as we use them, that is a far point, but you need to throw an InvalidConfiguration exception in such a case.

I personally agree with that, but maybe we can track this issue and address with a dedicated PR.

I personally agree with that, but maybe we can track this issue and address with a dedicated PR.

Sorry, but no. This PR decided to touch it without any obvious reason to do so. So it should do it properly or not at all.

@OwenCorrigan76 please revert the configProviders refactoring. After that, we also don't need createConfigIfMissing and related tests. I opened #11349 to track the issue reported above.

scholzj · 2025-04-11T11:44:30Z

...perator/src/main/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilder.java

+
+        // print user config with Strimzi injections
+        if (!userConfig.getConfiguration().isBlank()) {
+            printSectionHeader("User provided configuration with Strimzi injections");


I think this was about the message in the config. Not about the condition.

scholzj · 2025-04-11T12:07:57Z

cluster-operator/src/test/java/io/strimzi/operator/cluster/model/KafkaClusterTest.java

+    }
+
+    @ParallelTest
+    public void testStrimziMetricsReporterNetworkPolicy() {


Can't this be simply part of the previous test? It seems you have the exact duplicate an just have different asserts.

scholzj · 2025-04-11T12:16:03Z

documentation/modules/con-common-configuration-properties.adoc


-For more information about setting up and deploying Prometheus and Grafana, see link:{BookURLDeploying}#assembly-metrics-str[Introducing Metrics to Kafka^].
+NOTE: Using `strimziMetricsReporter` is only supported in the Kafka component at the moment.


You should explain what Kafka component is ...

Suggested change

NOTE: Using `strimziMetricsReporter` is only supported in the Kafka component at the moment.

NOTE: Using `strimziMetricsReporter` is only supported in the Kafka brokers and controllers at the moment.

scholzj · 2025-04-11T12:16:40Z

documentation/modules/con-common-configuration-properties.adoc

-When metrics are enabled, they are exposed on port 9404.
+.Using Strimzi Metrics Reporter
+The `metricsConfig` property contains configurations for the {StrimziMetricsReporter}.
+When configured to use Strimzi Metrics Reporter, Strimzi exposes the metrics provided by Apache Kafka directly.


I do not think this means anything ... what exactly is direct here?

I would rather say something like:

Using the Strimzi Metrics Reporter, Kafka JMX reporter and Prometheus JMX Exporter Java agent are not required to expose metrics in Prometheus format via HTTP.

I think for user documentation, that is meaningless. If you want to explain the difference, you should focus on something that explains the value for them.

new attempt: The Strimzi Metrics Reporter offers a lightweight solution for exposing Kafka metrics in Prometheus format, eliminating the need for intermediate layers like JMX or Java agents, and avoiding complex mapping rules that can introduce latency.

What about leaving out the eliminating the need for intermediate layers like JMX or Java agents part? But yes, I think this looks reasonable.

scholzj · 2025-04-11T12:18:14Z

packaging/examples/metrics/prometheus-jmx-exporter/README.md

This just makes things confusing ... as long as the Strimzi Metrics reporter is not ready for its prime time, you should keep the JMX Prometheus stuff as the primary and keep the Strimzi Metrics exporter in a subfolder. If you keep both in subfolder you just confuse everyone to not know what to use! Please revert all these changes!

scholzj · 2025-04-11T12:19:57Z

systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaTemplates.java

+    public static KafkaBuilder kafkaWithStrimziMetricsReporter(String namespaceName, String kafkaClusterName, int kafkaReplicas) {
+        KafkaBuilder kafkaBuilder = kafka(namespaceName, kafkaClusterName, kafkaReplicas)
+            .editSpec()
+                .editKafka()
+                    .withNewStrimziMetricsReporterConfig()
+                        .withNewValues()
+                            .withAllowList("kafka_server.*")
+                        .endValues()
+                    .endStrimziMetricsReporterConfig()
+                .endKafka()
+            .endSpec();
+
+        return kafkaBuilder;
+    }


Maybe more question on @strimzi/system-test-contributors ... but why do we need this method? It is called from one place and does not add much value. It can be easily inlined and make the readability of the whole test much better because you would see right away what the actual configuration is.

OwenCorrigan76 requested review from a team and mimaison January 16, 2025 17:15

OwenCorrigan76 force-pushed the integrate_metrics_reporter branch 2 times, most recently from e569be2 to 1180ee2 Compare January 16, 2025 17:23

scholzj reviewed Jan 16, 2025

View reviewed changes

OwenCorrigan76 force-pushed the integrate_metrics_reporter branch from 1180ee2 to f943007 Compare January 17, 2025 12:00

fvaleri added this to the 0.46.0 milestone Jan 17, 2025

OwenCorrigan76 changed the title ~~Add support for the Strimzi Metrics Reporter to Kafka component~~ Add support for the Strimzi Metrics Reporter to Kafka brokers/controllers components Jan 17, 2025

scholzj reviewed Jan 19, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

api/src/main/java/io/strimzi/api/kafka/model/common/metrics/StrimziMetricsReporterValues.java Outdated Show resolved Hide resolved

scholzj reviewed Jan 19, 2025

View reviewed changes

api/src/main/java/io/strimzi/api/kafka/model/common/metrics/JmxPrometheusExporterMetrics.java Show resolved Hide resolved

scholzj mentioned this pull request Jan 22, 2025

Add support for CEL validation to our CRDs #11068

Merged

4 tasks

OwenCorrigan76 force-pushed the integrate_metrics_reporter branch 2 times, most recently from 84fb016 to 8f5b28f Compare February 13, 2025 11:16

scholzj reviewed Feb 16, 2025

View reviewed changes

OwenCorrigan76 force-pushed the integrate_metrics_reporter branch 3 times, most recently from ece3b1f to 75a829f Compare February 24, 2025 13:23

fvaleri reviewed Feb 25, 2025

View reviewed changes

...perator/src/main/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilder.java Outdated Show resolved Hide resolved

OwenCorrigan76 force-pushed the integrate_metrics_reporter branch from 4304607 to f88ec2c Compare February 26, 2025 10:51

OwenCorrigan76 requested a review from fvaleri February 26, 2025 12:36

fvaleri reviewed Feb 26, 2025

View reviewed changes

OwenCorrigan76 force-pushed the integrate_metrics_reporter branch 2 times, most recently from 3c94f43 to 3969049 Compare March 4, 2025 12:21

ocorriga and others added 21 commits April 10, 2025 10:31

address latest comments

d45d5f0

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Add StrimziMetricsReporterConfig class

3d0e491

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Add defaults for allowlist

9cb1fb4

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Refactor withUserConfiguration and add tests

c7ffd1a

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Address Comments

0e21b3d

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Revert Connect script ENV VAR

8fee593

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Address Comments on common-configuration doc and fix typos

2bab6fc

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Fix ConfigMap naming for tests

e091150

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Address additional Comments

2fff0ca

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Address Jakub's and Tina's Comments

4251b3e

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Add comments to distinguish between kafka and yammer metrics

f998685

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Address Paolo's comments

44ce0ec

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Remove added comment writer.println

63e7891

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Refactor behaviour of user config in KafkaBrokerConfigurationBuilder

ee6b446

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Address Fede's comments

997bb2a

Signed-off-by: ocorriga <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Address Mickael's comments

b63116e

Signed-off-by: OwenCorrigan76 <[email protected]>

Fix Kafka dashboard

81b5b86

Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Update API doc

f87ddf9

Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Add system test

0bb5397

Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Minor ST improvements

55d6af2

Signed-off-by: Federico Valeri <[email protected]> Signed-off-by: OwenCorrigan76 <[email protected]>

Address Kate's and Paolo's comments

7e16090

Signed-off-by: OwenCorrigan76 <[email protected]>

OwenCorrigan76 force-pushed the integrate_metrics_reporter branch from b6ea886 to 7e16090 Compare April 10, 2025 09:32

Remove jayway-json-path dependency from kafka-thirdparty-libs and add…

b666550

… listener.enabed=true Signed-off-by: OwenCorrigan76 <[email protected]>

OwenCorrigan76 force-pushed the integrate_metrics_reporter branch from e7e8dc5 to b666550 Compare April 10, 2025 10:40

katheris approved these changes Apr 10, 2025

View reviewed changes

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java Outdated Show resolved Hide resolved

Address nit and move prometheus-jmx-exporter examples into it's own d…

70c5420

…irectory Signed-off-by: OwenCorrigan76 <[email protected]>

scholzj reviewed Apr 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for the Strimzi Metrics Reporter to Kafka brokers/controllers components #11051

Add support for the Strimzi Metrics Reporter to Kafka brokers/controllers components #11051

OwenCorrigan76 commented Jan 16, 2025 •

edited

Loading

scholzj left a comment

OwenCorrigan76 commented Jan 17, 2025

scholzj left a comment

fvaleri commented Feb 17, 2025 •

edited

Loading

OwenCorrigan76 commented Feb 17, 2025

scholzj commented Feb 17, 2025

OwenCorrigan76 commented Feb 25, 2025

fvaleri left a comment

fvaleri left a comment •

edited

Loading

fvaleri left a comment

katheris commented Apr 10, 2025

azure-pipelines bot commented Apr 10, 2025

katheris left a comment

katheris commented Apr 10, 2025

scholzj Apr 11, 2025

scholzj Apr 11, 2025

scholzj Apr 11, 2025

scholzj Apr 11, 2025

fvaleri Apr 11, 2025

scholzj Apr 11, 2025

fvaleri Apr 11, 2025 •

edited

Loading

scholzj Apr 11, 2025

fvaleri Apr 11, 2025

scholzj Apr 11, 2025

scholzj Apr 11, 2025

scholzj Apr 11, 2025

scholzj Apr 11, 2025

fvaleri Apr 11, 2025

scholzj Apr 11, 2025

fvaleri Apr 11, 2025

scholzj Apr 11, 2025

scholzj Apr 11, 2025

scholzj Apr 11, 2025

		if (model instanceof SupportsMetrics supportsMetrics && supportsMetrics.metrics() instanceof JmxPrometheusExporterModel) {
		String parseResult = ((JmxPrometheusExporterModel) supportsMetrics.metrics()).metricsJson(reconciliation, metricsAndLogging.metricsCm());

		@@ -105,7 +109,7 @@ public class CruiseControl extends AbstractModel implements SupportsMetrics, Sup

		// Configuration defaults
		protected static final boolean DEFAULT_CRUISE_CONTROL_METRICS_ENABLED = false;


		For more information about setting up and deploying Prometheus and Grafana, see link:{BookURLDeploying}#assembly-metrics-str[Introducing Metrics to Kafka^].
		NOTE: Using `strimziMetricsReporter` is only supported in the Kafka component at the moment.

Add support for the Strimzi Metrics Reporter to Kafka brokers/controllers components #11051

Are you sure you want to change the base?

Add support for the Strimzi Metrics Reporter to Kafka brokers/controllers components #11051

Conversation

OwenCorrigan76 commented Jan 16, 2025 • edited Loading

Type of change

Description

Checklist

scholzj left a comment

Choose a reason for hiding this comment

OwenCorrigan76 commented Jan 17, 2025

scholzj left a comment

Choose a reason for hiding this comment

fvaleri commented Feb 17, 2025 • edited Loading

OwenCorrigan76 commented Feb 17, 2025

scholzj commented Feb 17, 2025

OwenCorrigan76 commented Feb 25, 2025

fvaleri left a comment

Choose a reason for hiding this comment

fvaleri left a comment • edited Loading

Choose a reason for hiding this comment

fvaleri left a comment

Choose a reason for hiding this comment

katheris commented Apr 10, 2025

azure-pipelines bot commented Apr 10, 2025

katheris left a comment

Choose a reason for hiding this comment

katheris commented Apr 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fvaleri Apr 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OwenCorrigan76 commented Jan 16, 2025 •

edited

Loading

fvaleri commented Feb 17, 2025 •

edited

Loading

fvaleri left a comment •

edited

Loading

fvaleri Apr 11, 2025 •

edited

Loading