-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PEM certificates loaded from secrets for KafkaConnect #11198
base: main
Are you sure you want to change the base?
Conversation
b26740e
to
33a167a
Compare
@scholzj @ppatierno @katheris can one of you please kick off the regression tests? I ran some of the relevant ST locally which seemed to pass, but there are many I haven't run so would like to try running the full suite. Thanks! |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
thanks @scholzj for kicking off the tests. Looks like the failing tests are not related to this PR (time out failures in CruiseControlST which doesn't deploy any connect resource). I will mark this PR ready for review now :) . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some nits, but otherwise it mostly looks good.
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaConnectCluster.java
Show resolved
Hide resolved
b6cedbf
to
5e44da7
Compare
...erator/src/main/java/io/strimzi/operator/cluster/model/KafkaConnectConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
...erator/src/main/java/io/strimzi/operator/cluster/model/KafkaConnectConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/strimzi/api/kafka/model/connect/KafkaConnectResources.java
Outdated
Show resolved
Hide resolved
...erator/src/main/java/io/strimzi/operator/cluster/model/KafkaConnectConfigurationBuilder.java
Show resolved
Hide resolved
...erator/src/main/java/io/strimzi/operator/cluster/model/KafkaConnectConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/strimzi/api/kafka/model/connect/KafkaConnectResources.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/strimzi/api/kafka/model/connect/KafkaConnectResources.java
Outdated
Show resolved
Hide resolved
...erator/src/main/java/io/strimzi/operator/cluster/model/KafkaConnectConfigurationBuilder.java
Show resolved
Hide resolved
888109a
to
0352e9e
Compare
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaConnectCluster.java
Outdated
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
I created an issue for this PR to discuss some of the points that would also apply when making the other operands use PEM files as well. I thought it would be easier to discuss in an issue than the PR. |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Tina!
sorry If I approved but didn't notice your comment on #11294 so I guess we need more discussion.
@ppatierno @katheris @fvaleri I have made a change to create an internal secret for trusted certificates for OAuth server when OAuth is used. Can you please review the new change when you have time? Thank you. Can someone also please kick off the regression tests? Thanks! |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
I'm having an issue with oauth truststore configuration. It seems like Jaas config for the oauth, doesn't like new lines of PEM format certificates. It wants everything inline I think:
I also hit different issue with kafka-client 4.0 jar:
Looks it might be Java version incompatibility. So I'm looking into how to solve this issue. Maybe oauth.ssl.truststore.location in Oauth Jaas config is less complex way to configure it, but we need to combine the trusted certificates into a single file and volume mount it. I don't know if this is too complex, but we could copy oauth trusted cert secrets into an internal secret under a single key and volume mount this internal secret. |
Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
Remove volume mounts for TLS secrets Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
…or MM2 Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
Type of change
Select the type of your PR
Description
ssl.truststore.certificates
configuration. OAuth truststore is however configured differently, because multiline line certificates in Jaas config is not parsed correctly. Instead it will continue to usessl.truststore.location
which maps to the given secret's volume mount path for the certificate in PEM format.Resolves part of #11294
Checklist
Please go through this checklist and make sure all applicable tasks have been done