Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for signing manifest #11342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Apr 10, 2025

Type of change

Select the type of your PR

  • Bugfix
  • Enhancement / new feature

Description

This PR increases the default timeout for the cosign CLI from 3 to 6 minutes. We’ve observed frequent signing failures in main branch builds, likely due to timeouts. Extending the timeout is a first step to mitigate these issues and assess whether it improves reliability.

Checklist

  • Make sure all tests pass

@see-quick see-quick added this to the 0.46.0 milestone Apr 10, 2025
@see-quick see-quick requested a review from a team April 10, 2025 07:34
@see-quick see-quick self-assigned this Apr 10, 2025
@ppatierno
Copy link
Member

So of course we don't know if it fixes the issue because we are not going through the push containers stage. @see-quick should we try to merge this one as simpler solution and see if it works? if not coming back to the #11339? Wdyt?

@see-quick
Copy link
Member Author

see-quick commented Apr 11, 2025

So of course we don't know if it fixes the issue because we are not going through the push containers stage. @see-quick should we try to merge this one as simpler solution and see if it works? if not coming back to the #11339? Wdyt?

Yes, that’s how I envision it as well. I’ll keep an eye on the changes once this PR is merged. I plan to merge it on Monday—I’d rather not risk something breaking and creating work for myself this evening 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants