Server Side Apply phase 1 - ConfigMap, Ingress, Service, ServiceAccount, PVC#11693
Merged
im-konge merged 7 commits intostrimzi:mainfrom Aug 14, 2025
Merged
Server Side Apply phase 1 - ConfigMap, Ingress, Service, ServiceAccount, PVC#11693im-konge merged 7 commits intostrimzi:mainfrom
im-konge merged 7 commits intostrimzi:mainfrom
Conversation
im-konge
force-pushed
the
server-side-apply-vol1
branch
from
6600613 to
7b8441b
Compare
Member
Author
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
im-konge
force-pushed
the
server-side-apply-vol1
branch
from
7b8441b to
cc069b1
Compare
Member
Author
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
reviewed
Jul 28, 2025
im-konge
force-pushed
the
server-side-apply-vol1
branch
6 times, most recently
from
20134c9 to
b3f010a
Compare
Member
Author
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
im-konge
force-pushed
the
server-side-apply-vol1
branch
from
b3f010a to
33edea1
Compare
ppatierno
reviewed
Aug 1, 2025
im-konge
force-pushed
the
server-side-apply-vol1
branch
from
ec1fe1c to
976e65b
Compare
Member
Author
|
@scholzj thanks for the review, JFYI I added the UT for SSA with conflict and usage of force = true. |
Member
|
BTW: You are missing docs? |
Member
Author
|
Yeah, should I add them in this PR or in another one? Also, should it be just about the feature gate? Or something more? |
Member
It should be pretty straigth forward, so I would do it here. |
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Member
Author
|
@scholzj Docs for the FG added. Thanks for reminding me |
ppatierno
approved these changes
Aug 11, 2025
Member
ppatierno
left a comment
ppatierno
left a comment
There was a problem hiding this comment.
LGTM. I left just one question, but I guess I know the answer :-)
Member
Author
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/packit test --labels regression,upgrade |
Member
Author
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PaulRMellor
approved these changes
Aug 13, 2025
Contributor
PaulRMellor
left a comment
PaulRMellor
left a comment
There was a problem hiding this comment.
Looks good.
I left some suggestions for the supporting doc.
Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> Signed-off-by: Lukáš Král <53821852+im-konge@users.noreply.github.com>
Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> Signed-off-by: Lukáš Král <53821852+im-konge@users.noreply.github.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Member
Author
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
pushed a commit
to see-quick/strimzi-kafka-operator
that referenced
this pull request
Sep 4, 2025
…nt, PVC (strimzi#11693) Signed-off-by: Lukas Kral <lukywill16@gmail.com> Signed-off-by: Lukáš Král <53821852+im-konge@users.noreply.github.com> Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
As described in strimzi/proposals#160, this PR adds support for Server Side Apply for first five resources -
ConfigMap,Ingress,Service,ServiceAccount,PVC.It also adds feature gate for this phase -
ServerSideApplyPhase1.Checklist