Move methods not related to Vert.x out of VertxUtil class#11768
Merged
scholzj merged 1 commit intostrimzi:mainfrom Aug 29, 2025
Merged
Move methods not related to Vert.x out of VertxUtil class#11768scholzj merged 1 commit intostrimzi:mainfrom
scholzj merged 1 commit intostrimzi:mainfrom
Conversation
Signed-off-by: Jakub Scholz <www@scholzj.com>
Member
Author
|
/packit test --labels regression |
ppatierno
approved these changes
Aug 28, 2025
see-quick
pushed a commit
to see-quick/strimzi-kafka-operator
that referenced
this pull request
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The
VertxUtilclass in thecluster-operatormodule should contain only the methods related to Vert.x. But for some reason it seems to contain bunch of unrelated methods, which are used to get the hash of TLS certificates. This PR moves these methods and their tests to theReconcilerUtilsaas they are used by the AssemblyOperators and their reconcilers.This PR does not modify these methods in anyway (apart from changing one unnecessary modifier
/* test */toprivate).Checklist