Refactoring to return the NodeRef(s) for removed nodes#12055
Closed
ppatierno wants to merge 3 commits intostrimzi:mainfrom
Closed
Refactoring to return the NodeRef(s) for removed nodes#12055ppatierno wants to merge 3 commits intostrimzi:mainfrom
ppatierno wants to merge 3 commits intostrimzi:mainfrom
Conversation
Signed-off-by: Paolo Patierno <ppatierno@live.com>
see-quick
approved these changes
Oct 21, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12055 +/- ##
============================================
- Coverage 74.91% 74.90% -0.02%
+ Complexity 6454 6452 -2
============================================
Files 343 343
Lines 24336 24338 +2
Branches 3207 3208 +1
============================================
- Hits 18231 18230 -1
- Misses 4832 4834 +2
- Partials 1273 1274 +1
🚀 New features to boost your workflow:
|
Member
Author
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/gha run pipeline=regression |
|
⏳ System test verification started: link The following 6 job(s) will be executed:
Tests will start after successful build completion. |
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Member
Author
|
/azp run regression |
Member
Author
|
/gha run pipeline=regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
⏳ System test verification started: link The following 6 job(s) will be executed:
Tests will start after successful build completion. |
|
🎉 System test verification passed: link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
removedNodes()method to returnNodeRefwith all node's details instead of just the list of IDs.This way it's consistent with the
addedNodes()method.In general, having full node information can be useful (mostly if the removed node is broker, controller, ...) and I found it useful while working on some POC for the dynamic quorum and controllers scaling (because we are going to support removing controllers in the future).
I know this change doesn't help right now but I think having it in the main doesn't hurt. It could come useful for other stuff.