Skip to content

Fixed HTTP bridge related Prometheus rules#12057

Merged
ppatierno merged 1 commit intostrimzi:mainfrom
ppatierno:fix-bridge-prometheus-rules
Oct 22, 2025
Merged

Fixed HTTP bridge related Prometheus rules#12057
ppatierno merged 1 commit intostrimzi:mainfrom
ppatierno:fix-bridge-prometheus-rules

Conversation

@ppatierno
Copy link
Copy Markdown
Member

Type of change

  • Bugfix

Description

It seems that since Vert.x 4.x the naming convention for the metrics related to the HTTP server requests total changed.

In previous version Vert.x 3.x it was using requestCount as per here https://github.com/vert-x3/vertx-micrometer-metrics/blob/master/src/main/java/io/vertx/micrometer/MetricsNaming.java#L167 so the exposed metric was strimzi_bridge_http_server_requestCount_total.
From Vert.x 4.x it has been using "requests" as per here https://github.com/vert-x3/vertx-micrometer-metrics/blob/master/src/main/java/io/vertx/micrometer/MetricsNaming.java#L211 so the exposed metric is strimzi_bridge_http_server_requests_total.

It means that the current provided Prometheus rules using old strimzi_bridge_http_server_requestCount_total are not working anymore and they should use strimzi_bridge_http_server_requests_total instead.

This was raised via strimzi/strimzi-kafka-bridge#1034

Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno ppatierno added this to the 0.49.0 milestone Oct 22, 2025
@ppatierno ppatierno requested a review from a team October 22, 2025 11:36
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.80%. Comparing base (160ad2f) to head (5406a91).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12057      +/-   ##
============================================
+ Coverage     74.79%   74.80%   +0.01%     
- Complexity     6616     6617       +1     
============================================
  Files           376      376              
  Lines         25325    25325              
  Branches       3389     3389              
============================================
+ Hits          18941    18944       +3     
+ Misses         4998     4996       -2     
+ Partials       1386     1385       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppatierno ppatierno merged commit 3415bcd into strimzi:main Oct 22, 2025
25 checks passed
@ppatierno ppatierno deleted the fix-bridge-prometheus-rules branch October 22, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants