Fixed HTTP bridge related Prometheus rules#12057
Merged
ppatierno merged 1 commit intostrimzi:mainfrom Oct 22, 2025
Merged
Conversation
Signed-off-by: Paolo Patierno <ppatierno@live.com>
im-konge
approved these changes
Oct 22, 2025
see-quick
approved these changes
Oct 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12057 +/- ##
============================================
+ Coverage 74.79% 74.80% +0.01%
- Complexity 6616 6617 +1
============================================
Files 376 376
Lines 25325 25325
Branches 3389 3389
============================================
+ Hits 18941 18944 +3
+ Misses 4998 4996 -2
+ Partials 1386 1385 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
It seems that since Vert.x 4.x the naming convention for the metrics related to the HTTP server requests total changed.
In previous version Vert.x 3.x it was using
requestCountas per here https://github.com/vert-x3/vertx-micrometer-metrics/blob/master/src/main/java/io/vertx/micrometer/MetricsNaming.java#L167 so the exposed metric wasstrimzi_bridge_http_server_requestCount_total.From Vert.x 4.x it has been using "requests" as per here https://github.com/vert-x3/vertx-micrometer-metrics/blob/master/src/main/java/io/vertx/micrometer/MetricsNaming.java#L211 so the exposed metric is
strimzi_bridge_http_server_requests_total.It means that the current provided Prometheus rules using old
strimzi_bridge_http_server_requestCount_totalare not working anymore and they should usestrimzi_bridge_http_server_requests_totalinstead.This was raised via strimzi/strimzi-kafka-bridge#1034