Clean up KafkaRoller class

[katheris]

Type of change

Select the type of your PR

• Refactoring

Description

• Use milliseconds as time unit throughout.
• Remove unused method getBrokersLogging.
• Remove throws that are never thrown.
• Remove ForceableProblem.forceNow boolean which is always false.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

• Write tests
• Make sure all tests pass
• Update documentation
• Check RBAC rights for Kubernetes / OpenShift roles
• Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
• Reference relevant issue(s) and close them after merging
• Update CHANGELOG.md
• Supply screenshots for visual changes, such as Grafana dashboards

[codecov]

Codecov Report

❌ Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.78%. Comparing base (39ee260) to head (4d64cf9).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...perator/cluster/operator/resource/KafkaRoller.java	86.66%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12256      +/-   ##
============================================
- Coverage     74.78%   74.78%   -0.01%     
  Complexity     6628     6628              
============================================
  Files           377      377              
  Lines         25362    25359       -3     
  Branches       3402     3403       +1     
============================================
- Hits          18968    18964       -4     
- Misses         5006     5007       +1     
  Partials       1388     1388              

Files with missing lines	Coverage Δ
...perator/cluster/operator/resource/KafkaRoller.java	77.39% <86.66%> (+0.08%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[scholzj]

LGTM assuming it works.

I think it is fascinating how many internal APIs and methods use time and timeunit in their signature despite it clearly being completely useless because it always uses the same unit anyway. Maybe someone at some university should as some PhD work calculate how much waste does it create in the whole world 🤔

[katheris]

/gha run pipeline=upgrade,regression

[github-actions]

⏳ System test verification started: link

The following 10 job(s) will be executed:

• regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
• regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
• regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)
• upgrade-azp_kraft_upgrade-amd64 (oracle-vm-4cpu-16gb-x86-64)
• upgrade-azp_kafka_upgrade-amd64 (oracle-vm-4cpu-16gb-x86-64)
• upgrade-azp_kraft_upgrade-arm64 (oracle-vm-4cpu-16gb-arm64)
• upgrade-azp_kafka_upgrade-arm64 (oracle-vm-4cpu-16gb-arm64)

Tests will start after successful build completion.

[github-actions]

🎉 System test verification passed: link