Clarify OAuth issuer checking behavior#12758
Conversation
Signed-off-by: halo <dongjin778@naver.com>
There was a problem hiding this comment.
@won-seoop Thanks for the PR. You will need to rebuild the whole project to update the generated documentation from the api/src/main/java/io/strimzi/api/kafka/model/kafka/listener/KafkaListenerAuthenticationOAuth.java changes.
|
@scholzj I rebuilt the project with Java 21 using The rebuild completed successfully and did not produce any additional tracked changes. Could you please let me know if there is another generated artifact you expected me to update? |
|
Ahh, sorry. I didn't realized few things:
So I think you should close this PR and open a new one for the main branch which fixes the docs only. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.0.x #12758 +/- ##
================================================
Coverage 75.05% 75.06%
- Complexity 6512 6513 +1
================================================
Files 377 377
Lines 25092 25092
Branches 3269 3269
================================================
+ Hits 18833 18835 +2
+ Misses 4917 4915 -2
Partials 1342 1342 🚀 New features to boost your workflow:
|
|
Thanks for clarifying. I opened a docs-only PR against main in #12776, so I'll close this one. |
Type of change
Description
Clarifies that issuer checking still uses
validIssuerUriwhen it is configured, even ifcheckIssueris set tofalse.Also adds the equivalent note for JAAS-based OAuth configuration, where
oauth.valid.issuer.urishould be omitted when disabling issuer checking withoauth.check.issuer="false".Closes #12453
Checklist
Verification
mvn -pl api -DskipTests compilemake docu_check