Skip to content

Clarify OAuth issuer checking behavior#12758

Closed
won-seoop wants to merge 1 commit into
strimzi:release-1.0.xfrom
won-seoop:12453-check-issuer-docs
Closed

Clarify OAuth issuer checking behavior#12758
won-seoop wants to merge 1 commit into
strimzi:release-1.0.xfrom
won-seoop:12453-check-issuer-docs

Conversation

@won-seoop
Copy link
Copy Markdown

Type of change

  • Documentation

Description

Clarifies that issuer checking still uses validIssuerUri when it is configured, even if checkIssuer is set to false.

Also adds the equivalent note for JAAS-based OAuth configuration, where oauth.valid.issuer.uri should be omitted when disabling issuer checking with oauth.check.issuer="false".

Closes #12453

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Verification

  • mvn -pl api -DskipTests compile
  • make docu_check

Signed-off-by: halo <dongjin778@naver.com>
Copy link
Copy Markdown
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@won-seoop Thanks for the PR. You will need to rebuild the whole project to update the generated documentation from the api/src/main/java/io/strimzi/api/kafka/model/kafka/listener/KafkaListenerAuthenticationOAuth.java changes.

@scholzj scholzj requested review from PaulRMellor and mstruk May 22, 2026 08:57
@scholzj scholzj added this to the 1.1.0 milestone May 24, 2026
@won-seoop
Copy link
Copy Markdown
Author

@scholzj I rebuilt the project with Java 21 using mvn clean -DskipTests install, then ran make crd_install and make docu_check.

The rebuild completed successfully and did not produce any additional tracked changes. Could you please let me know if there is another generated artifact you expected me to update?

@scholzj
Copy link
Copy Markdown
Member

scholzj commented May 29, 2026

Ahh, sorry. I didn't realized few things:

  • You opened this PR for the 1.0.0 release branch. But we will not do anything with it here unless we do another patch release for 1.0.x
  • This class is actually not used anymore in man branch, but the doc still does

So I think you should close this PR and open a new one for the main branch which fixes the docs only.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.06%. Comparing base (4836c7d) to head (d27e0ec).

Additional details and impacted files
@@               Coverage Diff                @@
##             release-1.0.x   #12758   +/-   ##
================================================
  Coverage            75.05%   75.06%           
- Complexity            6512     6513    +1     
================================================
  Files                  377      377           
  Lines                25092    25092           
  Branches              3269     3269           
================================================
+ Hits                 18833    18835    +2     
+ Misses                4917     4915    -2     
  Partials              1342     1342           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@won-seoop
Copy link
Copy Markdown
Author

Thanks for clarifying. I opened a docs-only PR against main in #12776, so I'll close this one.

@won-seoop won-seoop closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants