Improve MirrorMaker example grafana dashboards and yaml#12777
Open
tinaselenge wants to merge 3 commits into
Open
Improve MirrorMaker example grafana dashboards and yaml#12777tinaselenge wants to merge 3 commits into
tinaselenge wants to merge 3 commits into
Conversation
Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12777 +/- ##
============================================
+ Coverage 75.02% 75.19% +0.16%
- Complexity 6386 6459 +73
============================================
Files 345 346 +1
Lines 24137 24329 +192
Branches 3091 3120 +29
============================================
+ Hits 18108 18293 +185
- Misses 4800 4802 +2
- Partials 1229 1234 +5 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
Current MirrorMaker Dashboard (not including Workers and JVM section below because they are not changed in this PR):
Issues fixed are:
After the update:

(JMX dashboard)
(Strimzi Metrics Reporter dashboard)

Several queries needed to be updated for Strimzi Metrics Reporter dashboard as some metric names and labels are different. One remaining issue for the Strimzi Metrics Reporter is Consumer Lag panels, because queries are updated to filter on source cluster's consumer specifically (works for JMX). For some reason, only data that is being emitted is internal topic consumers. I will further investigate and raise an issue to fix in another PR.
This PR also updates the example yaml for KafkaMirrorMaker2 CR to demo some of the best practices with comments explaining the reasons.
These changes brings more opinionated way to deploy and monitor metrics for MirrorMaker.
Checklist
Please go through this checklist and make sure all applicable tasks have been done