Skip to content

Upgrade to React 19 #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade to React 19 #585

wants to merge 2 commits into from
+66 −78

Conversation

bagedevimo
Copy link

Summary & motivation

  • Upgrade React and associated packages & types to React 19.x
  • Convert React imports to use the recommended import syntax

Testing & documentation

I compared the output of dist/ on master vs this branch and checked each change was the expected change.

@bagedevimo
Upgrade React and associated packages & types to React 19.x
a019e25
@bagedevimo
Convert React imports to use the recommended import syntax
fa5d68a 
Doing so prevents any named imports leaking into the output type
definitions (.d.ts files) and follows with what seems to be the React
official recommendations [1].

The more 'correct' fix would be only import those components that are
needed by each component, but that's a bigger change.

[1] facebook/react#18102

Fixes stripe#569
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Apr 12, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Apr 12, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@stale Stale
Copy link

stale bot commented May 2, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 2, 2025
@bagedevimo
Copy link
Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This is definitely not stale. Stripe team, maybe add a tag or something to issues / MRs you have replied too so this stops happening?

@stale stale bot removed the stale label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bagedevimo