Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CardEditUIHandler for the CardEditUI #10462

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

toluo-stripe
Copy link
Contributor

@toluo-stripe toluo-stripe commented Mar 21, 2025

Summary

This will hold all the state for the content on the CardDetails UI. It will also emit changes to CardUpdateParams to the UpdatePaymentMethodInteractor.

CardUpdateParams is the model that holds all the properties that have changed.

It only supports CBC changes at the moment.

Untitled diagram-2025-03-14-151415

Motivation

Breaking up this PR
JIRA

https://docs.google.com/document/d/1mvmApRTfsmQd0A4-b6g8EGuerlF0VE6N2eHr1F19HSk/edit?tab=t.0#heading=h.gl2i202sfdwi

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

Copy link
Contributor

github-actions bot commented Mar 21, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │  0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.4 KiB │   7.4 KiB │  0 B │   7.1 KiB │   7.1 KiB │  0 B 
    other │  95.1 KiB │  95.1 KiB │ +3 B │ 182.4 KiB │ 182.4 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +3 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20144 │ 20144 │ 0 (+0 -0) 
   types │  6235 │  6235 │ 0 (+0 -0) 
 classes │  5026 │  5026 │ 0 (+0 -0) 
 methods │ 30045 │ 30045 │ 0 (+0 -0) 
  fields │ 17388 │ 17388 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3644 │ 3644 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
   29 KiB │ +4 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.7 KiB │ -3 B │    64 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │ +2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼───────────┼──────┼────────────────────────
 55.8 KiB │ +3 B │ 129.3 KiB │  0 B │ (total)

@toluo-stripe toluo-stripe marked this pull request as ready for review March 21, 2025 20:15
@toluo-stripe toluo-stripe requested review from a team as code owners March 21, 2025 20:15
Copy link
Collaborator

@amk-stripe amk-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this in once it's actually being used, rather than checking in unused code. I think a natural way to merge in this initial change would be to just replace the existing card details UI with this new UI and its handler. So I would also expect that all the card brand choice changes are included in the initial PR, but probably not the "card details" parts (presumably those are the other fields that will be changed as part of the edit card project)

@toluo-stripe toluo-stripe force-pushed the tolu/uspm/card_edit_handler branch from 5a49c4e to 918bf9a Compare March 24, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants