-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce CardEditUIHandler for the CardEditUI #10462
base: master
Are you sure you want to change the base?
Conversation
Diffuse output:
APK
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge this in once it's actually being used, rather than checking in unused code. I think a natural way to merge in this initial change would be to just replace the existing card details UI with this new UI and its handler. So I would also expect that all the card brand choice changes are included in the initial PR, but probably not the "card details" parts (presumably those are the other fields that will be changed as part of the edit card project)
5a49c4e
to
918bf9a
Compare
This reverts commit 918bf9a.
Summary
This will hold all the state for the content on the CardDetails UI. It will also emit changes to
CardUpdateParams
to theUpdatePaymentMethodInteractor
.CardUpdateParams
is the model that holds all the properties that have changed.It only supports CBC changes at the moment.
Motivation
Breaking up this PR
JIRA
https://docs.google.com/document/d/1mvmApRTfsmQd0A4-b6g8EGuerlF0VE6N2eHr1F19HSk/edit?tab=t.0#heading=h.gl2i202sfdwi
Testing
Changelog