Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cash app afterpay. #10480

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Mar 24, 2025

Summary

Afterpay has updated branding in the US.

We switched from using the device locale to using the merchant currency, this matches what web does.

Motivation

https://jira.corp.stripe.com/browse/RUN_MOBILESDK-3986

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Screenshot_20250324_153631

Changelog

See changelog.

Copy link
Contributor

github-actions bot commented Mar 24, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼──────────┬──────────┬──────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff     
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
      dex │   4.1 MiB │   4.1 MiB │   +133 B │  9.1 MiB │  9.1 MiB │   +452 B 
     arsc │   2.4 MiB │   2.4 MiB │   +744 B │  2.4 MiB │  2.4 MiB │   +744 B 
 manifest │   5.2 KiB │   5.2 KiB │     -1 B │ 25.7 KiB │ 25.7 KiB │      0 B 
      res │ 909.3 KiB │ 909.3 KiB │     +1 B │  1.4 MiB │  1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │ -1.5 KiB │  1.6 MiB │  1.6 MiB │ -1.5 KiB 
    other │   1.4 MiB │   1.4 MiB │     -6 B │  1.6 MiB │  1.6 MiB │      0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
    total │    13 MiB │    13 MiB │   -620 B │ 22.2 MiB │ 22.2 MiB │   -295 B 

 DEX     │ old   │ new   │ diff         
─────────┼───────┼───────┼──────────────
   files │     1 │     1 │  0           
 strings │ 42930 │ 42931 │ +1 (+2 -1)   
   types │ 15400 │ 15400 │  0 (+0 -0)   
 classes │ 12997 │ 12997 │  0 (+0 -0)   
 methods │ 62919 │ 62920 │ +1 (+39 -38) 
  fields │ 41922 │ 41923 │ +1 (+1 -0)   

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  243 │  243 │  0         
 entries │ 6275 │ 6276 │ +1 (+1 -0)
APK
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  6.7 KiB │ -1.5 KiB │   6.5 KiB │ -1.5 KiB │ ∆ assets/dexopt/baseline.prof             
  2.4 MiB │   +744 B │   2.4 MiB │   +744 B │ ∆ resources.arsc                          
  4.1 MiB │   +133 B │   9.1 MiB │   +452 B │ ∆ classes.dex                             
   54 KiB │     -8 B │   120 KiB │      0 B │ ∆ META-INF/CERT.SF                        
 50.6 KiB │     +3 B │ 119.9 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
  1.2 KiB │     -2 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
    272 B │     +1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
  5.2 KiB │     -1 B │  25.7 KiB │      0 B │ ∆ AndroidManifest.xml                     
    797 B │     -1 B │   1.6 KiB │      0 B │ ∆ res/01.xml                              
  1.2 KiB │     -1 B │   3.9 KiB │      0 B │ ∆ res/2d.xml                              
  1.2 KiB │     -1 B │   3.7 KiB │      0 B │ ∆ res/BH.xml                              
    784 B │     +1 B │   1.6 KiB │      0 B │ ∆ res/Bh.xml                              
    907 B │     +1 B │   2.4 KiB │      0 B │ ∆ res/YB.xml                              
    952 B │     +1 B │   2.5 KiB │      0 B │ ∆ res/de.xml                              
    540 B │     +1 B │     952 B │      0 B │ ∆ res/zd.xml                              
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  6.6 MiB │   -620 B │  11.8 MiB │   -295 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   42930 │ 42931 │ +1 (+2 -1) 
  
  + , controller=null, currency=
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"ad5d0ad","r8-mode":"full","version":"8.8.27"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"75a2faf","r8-mode":"full","version":"8.8.27"}
  

METHODS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   62919 │ 62920 │ +1 (+39 -38) 
  
  + A3.h C(m, List, List) → ArrayList
  + Ia.e n0(int) → short
  + Ia.e o0(short) → short
  + Ia.e q0(short, short) → short
  + L5.M d0(w, m, l, List) → h
  + Q6.u b(m, N1, e) → a
  + Q6.u f(m, N1) → h
  + Q6.u g(m, N1, h) → ArrayList
  + Q6.v c(m, t) → List
  + Q6.w d(m, l, List) → h
  + Q6.w h(l, List) → boolean
  + R6.b b(m, N1, e) → a
  + R6.b d(m, l, List) → h
  + R6.b f(m, N1) → h
  + R6.b g(m, N1, h) → ArrayList
  + R6.b h(l, List) → boolean
  + R6.l c(m, t) → List
  + R6.l d(m, l, List) → h
  + R6.l h(l, List) → boolean
  + R6.r c(m, t) → List
  + R6.r d(m, l, List) → h
  + R6.r h(l, List) → boolean
  + S3.d m0(View, int) → boolean
  + Y8.F0 T(u, m, N1, e) → a
  + Y8.F0 w0(u, m, l, List) → h
  + Y8.i <init>(S, String)
  + a.a k0(v, m, l, List) → h
  + a.a l0(b1) → h0
  + a.a m0(View, int) → boolean
  + kotlin.ranges.a o0(float, float) → float
  + kotlin.ranges.a p0(double, double, double) → double
  + kotlin.ranges.a q0(float, float, float) → float
  + kotlin.ranges.a r0(int, int, int) → int
  + kotlin.ranges.a s0(long, long, long) → long
  + kotlin.ranges.a t0(long, LongRange) → long
  + kotlin.ranges.a u0(Comparable, ClosedFloatingPointRange) → Comparable
  + kotlin.ranges.a v0(IntRange) → IntProgression
  + kotlin.ranges.a w0(int, int) → IntRange
  + x3.a m0(View, int) → boolean
  
  - A3.h C(List, List) → ArrayList
  - Ia.e m0(int) → short
  - Ia.e n0(short) → short
  - Ia.e o0(short, short) → short
  - L5.M d0(w, l, List) → h
  - Q6.u c(N1) → h
  - Q6.u f(m, N1, h) → ArrayList
  - Q6.u h(N1, e) → a
  - Q6.v d(m, t) → List
  - Q6.w b(l, List) → h
  - Q6.w g(l, List) → boolean
  - R6.b b(l, List) → h
  - R6.b c(N1) → h
  - R6.b f(m, N1, h) → ArrayList
  - R6.b g(l, List) → boolean
  - R6.b h(N1, e) → a
  - R6.l b(l, List) → h
  - R6.l d(m, t) → List
  - R6.l g(l, List) → boolean
  - R6.r b(l, List) → h
  - R6.r d(m, t) → List
  - R6.r g(l, List) → boolean
  - S3.d l0(View, int) → boolean
  - Y8.F0 T(u, N1, e) → a
  - Y8.F0 w0(u, l, List) → h
  - Y8.i <init>(S)
  - a.a k0(b1) → h0
  - a.a l0(View, int) → boolean
  - kotlin.ranges.a m0(float, float) → float
  - kotlin.ranges.a o0(double, double, double) → double
  - kotlin.ranges.a p0(float, float, float) → float
  - kotlin.ranges.a q0(int, int, int) → int
  - kotlin.ranges.a r0(long, long, long) → long
  - kotlin.ranges.a s0(long, LongRange) → long
  - kotlin.ranges.a t0(Comparable, ClosedFloatingPointRange) → Comparable
  - kotlin.ranges.a u0(IntRange) → IntProgression
  - kotlin.ranges.a v0(int, int) → IntRange
  - x3.a l0(View, int) → boolean
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   41922 │ 41923 │ +1 (+1 -0) 
  
  + Y8.i b: String
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6275 │ 6276 │ +1 (+1 -0) 
  + string/stripe_cashapp_afterpay_subtitle

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/cashapp-afterpay branch 2 times, most recently from 548d1ab to 2d1d132 Compare March 24, 2025 21:12
@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/cashapp-afterpay branch from 2d1d132 to fecc9bb Compare March 24, 2025 21:47
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review March 24, 2025 22:29
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners March 24, 2025 22:29
@jaynewstrom-stripe jaynewstrom-stripe merged commit 6d329ae into master Mar 24, 2025
16 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/cashapp-afterpay branch March 24, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants