-
Notifications
You must be signed in to change notification settings - Fork 703
[Identity] Feedback to flip ID Document over if incorrect side is detected, center ID if off center, ID is too blurry, and if distance needs correction #11941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pearapps
wants to merge
15
commits into
master
Choose a base branch
from
kpa/feedback-additions-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Diffuse output: APKDEXARSC |
#11993) * Update IDDetectorTransitioner.kt * Update IDDetectorTransitionerTest.kt * closer and further * Update IDDetectorTransitioner.kt * Update IDDetectorTransitioner.kt * Update IDDetectorTransitioner.kt --------- Co-authored-by: Ken Ackerson <[email protected]>
cjmisenas-stripe
requested changes
Nov 26, 2025
identity/src/main/java/com/stripe/android/identity/states/IDDetectorTransitioner.kt
Show resolved
Hide resolved
identity/src/main/java/com/stripe/android/identity/states/IDDetectorTransitioner.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on: #12016
Adds in some live feedback if you are scanning the wrong side of the document for the side requested & to center the ID if it is not centered in the view frame; during document capture.
Also - this adds in some live feedback during document capture for when the id is too blurry or the distance is not correct and can be corrected.
Examples:
ID distance:
Focus:
Centering
Incorrect side: